Re: [PATCH][resubmit] x86: enable preemption in delay

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Gregory Haskins <ghaskins@...>
Cc: Peter Zijlstra <peterz@...>, Ingo Molnar <mingo@...>, Andi Kleen <andi-suse@...>, Clark Williams <clark.williams@...>, Steven Rostedt <rostedt@...>, Marin Mitov <mitov@...>, Thomas Gleixner <tglx@...>, Linus Torvalds <torvalds@...>, <akpm@...>, Luis Claudio R. Goncalves <lclaudio@...>, LKML <linux-kernel@...>, linux-rt-users <linux-rt-users@...>
Date: Wednesday, June 18, 2008 - 8:42 am

On Wednesday 18 June 2008 22:25, Gregory Haskins wrote:


It just seems like pretty worthless bloat to me.

There are _some_ cases where it can be used, but nobody has been
able to come up with compelling uses really. I don't think this
case is helped very much either because the logic in there using
preempt-disable is fine, isn't it?

Except that it should also have a cond_resched in it. Seems like
an ideal place to put cond_resched because it is not a fastpath.
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Re:[PATCH -v4] x86: enable preemption in delay, Marin Mitov, (Sun May 25, 2:08 pm)
Re:[PATCH -v4] x86: enable preemption in delay, Thomas Gleixner, (Sun May 25, 6:21 pm)
[PATCH][resubmit] x86: enable preemption in delay, Marin Mitov, (Sun Jun 1, 12:01 pm)
Re: [PATCH][resubmit] x86: enable preemption in delay, Marin Mitov, (Mon Jun 9, 12:11 pm)
Re: [PATCH][resubmit] x86: enable preemption in delay, Ingo Molnar, (Mon Jun 9, 12:16 pm)
Re: [PATCH][resubmit] x86: enable preemption in delay, Marin Mitov, (Sun Jun 15, 1:58 pm)
Re: [PATCH][resubmit] x86: enable preemption in delay, Ingo Molnar, (Wed Jun 18, 3:55 am)
Re: [PATCH][resubmit] x86: enable preemption in delay, Pavel Machek, (Sat Jun 28, 6:44 am)
Re: [PATCH][resubmit] x86: enable preemption in delay, Gregory Haskins, (Wed Jun 18, 8:08 am)
Re: [PATCH][resubmit] x86: enable preemption in delay, Peter Zijlstra, (Wed Jun 18, 8:16 am)
Re: [PATCH][resubmit] x86: enable preemption in delay, Gregory Haskins, (Wed Jun 18, 8:25 am)
Re: [PATCH][resubmit] x86: enable preemption in delay, Nick Piggin, (Wed Jun 18, 8:42 am)
Re: [PATCH][resubmit] x86: enable preemption in delay, Steven Rostedt, (Wed Jun 18, 12:16 pm)
Re: [PATCH][resubmit] x86: enable preemption in delay, Nick Piggin, (Wed Jun 18, 1:18 pm)
Re: [PATCH][resubmit] x86: enable preemption in delay, Gregory Haskins, (Wed Jun 18, 9:04 am)
Re: [PATCH][resubmit] x86: enable preemption in delay, Gregory Haskins, (Wed Jun 18, 8:13 am)
Re: [PATCH -v4] x86: enable preemption in delay, Marin Mitov, (Mon May 26, 1:14 am)
Re:[PATCH -v4] x86: enable preemption in delay, Steven Rostedt, (Sun May 25, 3:30 pm)
Re: [PATCH -v4] x86: enable preemption in delay, Marin Mitov, (Sun May 25, 3:58 pm)