Home » Mailing list archives » linux-kernel » 2008 » June » 17

Re: [PATCH] net: via-velocity.c fix sleep-with-spinlock bug during MTU change

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Francois Romieu
Subject: Re: [PATCH] net: via-velocity.c fix sleep-with-spinlock bug during MTU change
Date: Tuesday, June 17, 2008 - 2:45 pm

Séguier Régis <rseguier@e-teleport.net> :
[...]

Does the patch below make a difference ?

diff --git a/drivers/net/via-velocity.c b/drivers/net/via-velocity.c
index 71a5133..fa303da 100644
--- a/drivers/net/via-velocity.c
+++ b/drivers/net/via-velocity.c
@@ -1274,7 +1274,7 @@ static void velocity_free_rd_ring(struct velocity_info *vptr)
 				 PCI_DMA_FROMDEVICE);
 		rd_info->skb_dma = (dma_addr_t) NULL;
 
-		dev_kfree_skb(rd_info->skb);
+		dev_kfree_skb_any(rd_info->skb);
 		rd_info->skb = NULL;
 	}
 
@@ -1336,7 +1336,7 @@ static void velocity_free_td_ring_entry(struct velocity_info *vptr,
 				td_info->skb_dma[i] = (dma_addr_t) NULL;
 			}
 		}
-		dev_kfree_skb(td_info->skb);
+		dev_kfree_skb_any(td_info->skb);
 		td_info->skb = NULL;
 	}
 }
-- 
Ueimor
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH] net: via-velocity.c fix sleep-with-spinlock bug du ..., Arjan van de Ven, (Sat May 31, 6:46 pm)
Re: [PATCH] net: via-velocity.c fix sleep-with-spinlock bu ..., Andrew Morton, (Tue Jun 3, 1:40 pm)
Re: [PATCH] net: via-velocity.c fix sleep-with-spinlock bu ..., Francois Romieu, (Tue Jun 3, 2:51 pm)
Re: [PATCH] net: via-velocity.c fix sleep-with-spinlock bu ..., Francois Romieu, (Wed Jun 4, 2:59 pm)
Re: [PATCH] net: via-velocity.c fix sleep-with-spinlock bu ..., Francois Romieu, (Sat Jun 14, 2:23 pm)
Re: [PATCH] net: via-velocity.c fix sleep-with-spinlock bu ..., Séguier Régis, (Mon Jun 16, 2:25 pm)
Re: [PATCH] net: via-velocity.c fix sleep-with-spinlock bu ..., Francois Romieu, (Tue Jun 17, 2:45 pm)
Re: [PATCH] net: via-velocity.c fix sleep-with-spinlock bu ..., Séguier Régis, (Tue Jun 17, 4:37 pm)
Re: [PATCH] net: via-velocity.c fix sleep-with-spinlock bu ..., Séguier Régis, (Wed Jun 18, 9:56 am)
Re: [PATCH] net: via-velocity.c fix sleep-with-spinlock bu ..., Francois Romieu, (Wed Jun 18, 1:10 pm)
Re: [PATCH] net: via-velocity.c fix sleep-with-spinlock bu ..., Séguier Régis, (Wed Jun 18, 3:09 pm)
Re: [PATCH] net: via-velocity.c fix sleep-with-spinlock bu ..., Francois Romieu, (Thu Jun 19, 1:43 pm)
Re: [PATCH] net: via-velocity.c fix sleep-with-spinlock bu ..., Séguier Régis, (Fri Jun 20, 3:24 am)
Re: [PATCH] net: via-velocity.c fix sleep-with-spinlock bu ..., Francois Romieu, (Fri Jun 20, 3:39 am)
Re: [PATCH] net: via-velocity.c fix sleep-with-spinlock bu ..., Séguier Régis, (Fri Jun 20, 9:50 am)
Re: [PATCH] net: via-velocity.c fix sleep-with-spinlock bu ..., Séguier Régis, (Mon Jun 23, 10:04 am)