login
Login
/
Register
Search
Search this site:
Forums
News
Blogs
Features
Site
Home
»
Mailing list archives
»
linux-kernel
»
2008
»
June
»
15
Re: [PATCH 02/18] ide-cd: remove ide_cd_drain_data and ide_cd_pad_transfer
view
thread
Previous message: [
thread
] [
date
] [
author
]
Next message: [
thread
] [
date
] [
author
]
[view in full thread]
From: Borislav Petkov
Subject:
Re: [PATCH 02/18] ide-cd: remove ide_cd_drain_data and ide_cd_pad_transfer
Date: Sunday, June 15, 2008 - 2:28 am
On Sat, Jun 14, 2008 at 07:29:05PM +0200, Bartlomiej Zolnierkiewicz wrote:
quoted text
> On Thursday 12 June 2008, Borislav Petkov wrote: > > Use the generic ide_pad_transfer() helper instead > > > > Signed-off-by: Borislav Petkov <petkovbb@gmail.com> > > applied w/ ide_cd_drain_data() -> ide_pad_transfer() conversion fixup > > [...] > > > @@ -1006,7 +981,7 @@ static ide_startstop_t cdrom_newpc_intr(ide_drive_t *drive) > > - bio_cur_sectors(rq->bio), > > thislen >> 9); > > if (nskip > 0) { > > - ide_cd_drain_data(drive, nskip); > > + ide_pad_transfer(drive, write, nskip); > > rq->current_nr_sectors -= nskip; > > thislen -= (nskip << 9); > > } > > ide_cd_drain_data() took number for _sectors_ as an argument > while ide_pad_transfer() wants to be given number of _bytes_
/me crawls ashamed back into the black place behind the wall cardboard ... :)
quoted text
> > > @@ -1043,7 +1018,7 @@ static ide_startstop_t cdrom_newpc_intr(ide_drive_t *drive) > > * If the buffers are full, pipe the rest into > > * oblivion. > > */ > > - ide_cd_drain_data(drive, thislen >> 9); > > + ide_pad_transfer(drive, 0, thislen >> 9); > > ditto
-- Regards/Gruß, Boris. --
unsubscribe notice
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to
majordomo@vger.kernel.org
More majordomo info at
http://vger.kernel.org/majordomo-info.html
Please read the FAQ at
http://www.tux.org/lkml/
Previous message: [
thread
] [
date
] [
author
]
Next message: [
thread
] [
date
] [
author
]
Messages in current thread:
[PATCH 00/18] misc generic ide stuff
, Borislav Petkov
, (Wed Jun 11, 11:40 pm)
[PATCH 01/18] ide-cd: remove wait-for-idle-controller bit ...
, Borislav Petkov
, (Wed Jun 11, 11:40 pm)
[PATCH 02/18] ide-cd: remove ide_cd_drain_data and ide_cd_ ...
, Borislav Petkov
, (Wed Jun 11, 11:40 pm)
[PATCH 03/18] ide-cd: cdrom_decode_status: factor out bloc ...
, Borislav Petkov
, (Wed Jun 11, 11:40 pm)
[PATCH 04/18] ide-cd: cdrom_decode_status: factor out fs r ...
, Borislav Petkov
, (Wed Jun 11, 11:40 pm)
[PATCH 05/18] ide-cd: ide_do_rw_cdrom: add the catch-all b ...
, Borislav Petkov
, (Wed Jun 11, 11:40 pm)
[PATCH 06/18] ide-cd: cdrom_start_seek: remove unused argu ...
, Borislav Petkov
, (Wed Jun 11, 11:40 pm)
[PATCH 07/18] ide-cd: mv ide_do_rw_cdrom ide_cd_do_request
, Borislav Petkov
, (Wed Jun 11, 11:40 pm)
[PATCH 08/18] ide-cd: simplify request issuing path
, Borislav Petkov
, (Wed Jun 11, 11:41 pm)
[PATCH 09/18] ide-cd: fold cdrom_start_seek into ide_cd_do ...
, Borislav Petkov
, (Wed Jun 11, 11:41 pm)
[PATCH 10/18] ide-cd: move request prep from cdrom_start_s ...
, Borislav Petkov
, (Wed Jun 11, 11:41 pm)
[PATCH 11/18] ide-cd: move request prep from cdrom_start_r ...
, Borislav Petkov
, (Wed Jun 11, 11:41 pm)
[PATCH 12/18] ide-cd: move request prep chunk from cdrom_d ...
, Borislav Petkov
, (Wed Jun 11, 11:41 pm)
[PATCH 13/18] ide-floppy: replace pc->c with rq->cmd
, Borislav Petkov
, (Wed Jun 11, 11:41 pm)
[PATCH 14/18] ide-floppy: fold idefloppy_create_test_unit_ ...
, Borislav Petkov
, (Wed Jun 11, 11:41 pm)
[PATCH 15/18] ide-floppy: zero out the whole struct ide_at ...
, Borislav Petkov
, (Wed Jun 11, 11:41 pm)
[PATCH 16/18] ide-floppy: pass rq instead of pc to ideflop ...
, Borislav Petkov
, (Wed Jun 11, 11:41 pm)
[PATCH 17/18] ide-floppy: cleanup idefloppy_create_rw_cmd
, Borislav Petkov
, (Wed Jun 11, 11:41 pm)
[PATCH 18/18] ide: use flags in IRQ handler
, Borislav Petkov
, (Wed Jun 11, 11:41 pm)
Re: [PATCH 00/18] misc generic ide stuff
, Bartlomiej Zolnierki ...
, (Sat Jun 14, 10:29 am)
Re: [PATCH 02/18] ide-cd: remove ide_cd_drain_data and ide ...
, Bartlomiej Zolnierki ...
, (Sat Jun 14, 10:29 am)
Re: [PATCH 03/18] ide-cd: cdrom_decode_status: factor out ...
, Bartlomiej Zolnierki ...
, (Sat Jun 14, 10:29 am)
Re: [PATCH 13/18] ide-floppy: replace pc->c with rq->cmd
, Bartlomiej Zolnierki ...
, (Sat Jun 14, 10:40 am)
Re: [PATCH 18/18] ide: use flags in IRQ handler
, Bartlomiej Zolnierki ...
, (Sat Jun 14, 10:47 am)
Re: [PATCH 02/18] ide-cd: remove ide_cd_drain_data and ide ...
, Borislav Petkov
, (Sun Jun 15, 2:28 am)
Re: [PATCH 13/18] ide-floppy: replace pc->c with rq->cmd
, Borislav Petkov
, (Sun Jun 15, 3:21 am)
Re: [PATCH 00/18] misc generic ide stuff
, Borislav Petkov
, (Sun Jun 15, 3:27 am)
Re: [PATCH 13/18] ide-floppy: replace pc->c with rq->cmd
, Bartlomiej Zolnierki ...
, (Sun Jun 15, 7:57 am)
Re: [PATCH 03/18] ide-cd: cdrom_decode_status: factor out ...
, Borislav Petkov
, (Fri Aug 15, 12:34 am)
Re: [PATCH 03/18] ide-cd: cdrom_decode_status: factor out ...
, Borislav Petkov
, (Fri Aug 15, 12:34 am)
Re: [PATCH 03/18] ide-cd: cdrom_decode_status: factor out ...
, Borislav Petkov
, (Sat Aug 16, 1:26 pm)
Navigation
Mailing list archives
Recent posts
Popular discussions
linux-kernel
:
Mel Gorman
Re: [PATCH 1/4] vmstat: remove zone->lock from walk_zones_in_node
Guenter Roeck
Re: [lm-sensors] Location for thermal drivers
David Woodhouse
Re: RFC: Moving firmware blobs out of the kernel.
Siddha, Suresh B
Re: [PATCH 2.6.21 review I] [11/25] x86: default to physical mode on hotplug CPU k...
Peter Zijlstra
Re: [patch 4/6] mm: merge populate and nopage into fault (fixes nonlinear)
git-commits-head
:
Linux Kernel Mailing List
[MIPS] Fix potential latency problem due to non-atomic cpu_wait.
Linux Kernel Mailing List
USB: rename USB_SPEED_VARIABLE to USB_SPEED_WIRELESS
Linux Kernel Mailing List
lib/vsprintf.c: fix bug omitting minus sign of numbers (module_param)
Linux Kernel Mailing List
[Bluetooth] Initiate authentication during connection establishment
Linux Kernel Mailing List
[POWERPC] 4xx: Add ppc40x_defconfig
linux-netdev
:
MERCEDES
Your mail id has won 950,000.00 in the MERCEDES Benz Online Promo.for claims send:
David Miller
Re: [PATCH] xen/netfront: do not mark packets of length < MSS as GSO
David Miller
Re: skb_segment() questions
Shan Wei
[RFC PATCH net-next 2/5]IPv6:netfilter: Send an ICMPv6 "Fragment Reassembly Timeou...
Stanislaw Gruszka
[PATCH 1/4] bnx2x: use smp_mb() to keep ordering of read write operations
git
:
Nicolas Sebrecht
git-svn died of signal 11 (was "3 failures on test t9100 (svn)")
Junio C Hamano
Re: [PATCH 2/2] Add url.<base>.pushInsteadOf: URL rewriting for push only
Martin Langhoff
Re: [PATCH] GIT commit statistics.
Alexandre Julliard
[PATCH] gitweb: Put back shortlog instead of graphiclog in the project list.
Josh Triplett
[PATCH 2/2] Add url.<base>.pushInsteadOf: URL rewriting for push only
openbsd-misc
:
Taisto Qvist XX
Re: AMD GEODE LX-800 just works with kernel from install42.iso and kernelpanics wi...
Nico Meijer
Re: gOS Develop Kit with VIA pc-1 Processor Platform VIA C7-D
Andreas Bihlmaier
Re: jetway board sensors (Fintek F71805F)
admin
Drive a 2009 car from R799p/m
Antti Harri
Re: how to create a sha256 hash
Colocation donated by:
Syndicate