Home » Mailing list archives » linux-kernel » 2008 » June » 12

[PATCH 02/23] checkpatch: return is not a function -- parentheses for casts are ok too

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Andy Whitcroft
Subject: [PATCH 02/23] checkpatch: return is not a function -- parentheses for casts are ok too
Date: Thursday, June 12, 2008 - 5:05 am

Casts require parentheses so it is possible to have something like this:

	return (int)(*a);

This miss trips the complexity function.  Ensure that the two separate
parenthesised sections are not coelesced.

Signed-off-by: Andy Whitcroft <apw@shadowen.org>
---
 scripts/checkpatch.pl |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 66f060e..83ae37b 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -1670,6 +1670,7 @@ sub process {
 			my $value = $2;
 
 			# Flatten any parentheses and braces
+			$value =~ s/\)\(/\) \(/g;
 			while ($value =~ s/\([^\(\)]*\)/1/) {
 			}
 
-- 
1.5.6.rc0.140.ga9675

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
update checkpatch to version 0.20, Andy Whitcroft, (Thu Jun 12, 5:05 am)
[PATCH 01/23] checkpatch: Version: 0.20, Andy Whitcroft, (Thu Jun 12, 5:05 am)
[PATCH 02/23] checkpatch: return is not a function -- pare ..., Andy Whitcroft, (Thu Jun 12, 5:05 am)
[PATCH 03/23] checkpatch: types: some types may also be id ..., Andy Whitcroft, (Thu Jun 12, 5:05 am)
[PATCH 04/23] checkpatch: add a checkpatch warning for new ..., Andy Whitcroft, (Thu Jun 12, 5:05 am)
[PATCH 05/23] checkpatch: possible types: __asm__ is never ..., Andy Whitcroft, (Thu Jun 12, 5:05 am)
[PATCH 06/23] checkpatch: comment detection: ignore macro ..., Andy Whitcroft, (Thu Jun 12, 5:05 am)
[PATCH 07/23] checkpatch: types: unary -- goto introduces ..., Andy Whitcroft, (Thu Jun 12, 5:05 am)
[PATCH 08/23] checkpatch: macros: fix statement counting b ..., Andy Whitcroft, (Thu Jun 12, 5:05 am)
[PATCH 09/23] checkpatch: trailing statement indent: fix e ..., Andy Whitcroft, (Thu Jun 12, 5:05 am)
[PATCH 10/23] checkpatch: allow printk strings to exceed 8 ..., Andy Whitcroft, (Thu Jun 12, 5:05 am)
[PATCH 11/23] checkpatch: switch -- report trailing statem ..., Andy Whitcroft, (Thu Jun 12, 5:05 am)
[PATCH 12/23] checkpatch: check spacing for square brackets, Andy Whitcroft, (Thu Jun 12, 5:05 am)
[PATCH 13/23] checkpatch: toughen trailing if statement ch ..., Andy Whitcroft, (Thu Jun 12, 5:05 am)
[PATCH 14/23] checkpatch: condition/loop indent checks, Andy Whitcroft, (Thu Jun 12, 5:05 am)
[PATCH 15/23] checkpatch: usb_free_urb() can take NULL, Andy Whitcroft, (Thu Jun 12, 5:05 am)
[PATCH 16/23] checkpatch: correct spelling in kfree checks, Andy Whitcroft, (Thu Jun 12, 5:05 am)
[PATCH 17/23] checkpatch: allow for type modifiers on mult ..., Andy Whitcroft, (Thu Jun 12, 5:05 am)
[PATCH 18/23] checkpatch: improve type matcher debug, Andy Whitcroft, (Thu Jun 12, 5:05 am)
[PATCH 19/23] checkpatch: possible modifiers are not being ..., Andy Whitcroft, (Thu Jun 12, 5:05 am)
[PATCH 20/23] checkpatch: macro complexity checks are mean ..., Andy Whitcroft, (Thu Jun 12, 5:05 am)
[PATCH 21/23] checkpatch: handle return types of pointers ..., Andy Whitcroft, (Thu Jun 12, 5:06 am)
[PATCH 22/23] checkpatch: possible types -- known modifier ..., Andy Whitcroft, (Thu Jun 12, 5:06 am)
[PATCH 23/23] checkpatch: possible modifiers -- handle mul ..., Andy Whitcroft, (Thu Jun 12, 5:06 am)