Some comments about one routine; presumably more to follow: On Friday 06 June 2008, Guennadi Liakhovetski wrote:That's not what you implement though ... what it needs is: - transfer #1: * select * write 16 bit command, discard rx data * deselect - transfer #2 * select * write 16 bit command, saving rx data * deselect That's from the data sheet. Now, that *could* be implemented with a single message ... or, as you do, with two messages. You should at least correct the comment, if you don't want to switch to a slightly faster single-message implementation. :) Actually it returns a 16 bit value... also, "successful" has one "l". You seem to have forgotten to mask off the high byte ... Take out this FIXME, and just replace it with a note that this relies on the fact that TX always shifts out zeroes if there's no data specified. Oh, and in the probe(): should be ret = spi_setup(spi); if (ret < 0) return ret; It's quite possible that something get misconfigured, so you end up trying to talk through a spi_master controller that doesn't support 16-bit words. - Dave --
| Andy Whitcroft | Re: 2.6.23-rc6-mm1 |
| Greg KH | [GIT PATCH] driver core patches against 2.6.24 |
| James Bottomley | Re: Integration of SCST in the mainstream Linux kernel |
| Alan | Re: [RFC] Heads up on sys_fallocate() |
git: | |
| Natalie Protasevich | [BUG] New Kernel Bugs |
| Gerrit Renker | [PATCH 0/37] dccp: Feature negotiation - last call for comments |
| Jarek Poplawski | [PATCH] pkt_sched: Destroy gen estimators under rtnl_lock(). |
| Winkler, Tomas | RE: iwlwifi: fix build bug in "iwlwifi: fix LED stall" |
