linux-kernel mailing list

FromSubjectsort iconDate
Serge E. Hallyn
[PATCH -mm] mm/shmem.c: ret can be used uninitialized
From 6c4eb2ce2849308c4a745ec1f93001e5064a469c Mon Sep 17 00:00:00 2001 From: Serge Hallyn <serge@us.ibm.com> Date: Wed, 11 Jun 2008 11:20:28 -0500 Subject: [PATCH -mm] mm/shmem.c: ret can be used uninitialized Make sure ret is defined before check at line 1408. Signed-off-by: Serge Hallyn <serge@us.ibm.com> --- mm/shmem.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/mm/shmem.c b/mm/shmem.c index ad24be7..b326ff2 100644 --- a/mm/shmem.c +++ b/mm/shme...
Jun 11, 3:37 pm 2008
Serge E. Hallyn
[PATCH] cgroup_clone: use pid of newly created task for new ...
cgroup_clone creates a new cgroup with the pid of the task. This works correctly for unshare, but for clone cgroup_clone is called from copy_namespaces inside copy_process, which happens before the new pid is created. As a result, the new cgroup was created with current's pid. This patch: 1. Moves the call inside copy_process to after the new pid is created 2. Passes the struct pid into ns_cgroup_clone (as it is not yet attached to the task) 3. Passes a name from ns_cgroup_clone() in...
Jun 11, 3:35 pm 2008
David Miller
Re: [TCP]: TCP_DEFER_ACCEPT causes leak sockets
From: Alexey Kuznetsov <kuznet@ms2.inr.ac.ru> Yes, we discussed the locking issue over past few days. See the thread: "stuck localhost TCP connections, v2.6.26-rc3+" More and more, the arguments are mounting to completely revert the established code path changes, and frankly that is likely what I am going to do by the end of today. --
Jun 11, 7:52 pm 2008
Len Brown
[GIT PATCH] ACPI patches for 2.6.26-rc5
Hi Linus, please pull from: git://git.kernel.org/pub/scm/linux/kernel/git/lenb/linux-acpi-2.6.git release This will update the files shown below. thanks! -Len ps. individual patches are available on linux-acpi@vger.kernel.org and a consolidated plain patch is available here: ftp://ftp.kernel.org/pub/linux/kernel/people/lenb/acpi/patches/release/2.6.26/acpi-rel... Documentation/laptops/thinkpad-acpi.txt | 2 +- MAINTAINERS ...
Jun 11, 7:44 pm 2008
Gustavo Fernando Padovan
[PATCH] kernel/signal.c: change vars pid and tgid types to p...
Q2hhbmdlIHRoZSB0eXBlIG9mIHBpZCBhbmQgdGdpZCB2YXJpYWJsZXMgZnJvbSBpbnQgdG8gdGhl IFBPU0lYIHR5cGUgcGlkX3QuCgoKU2lnbmVkLW9mZi1ieTogR3VzdGF2byBGLiBQYWRvdmFuIDxn dXN0YXZvQGxhcy5pYy51bmljYW1wLmJyPgoKCi0tLSBhL2tlcm5lbC9zaWduYWwuYyAgMjAwOC0w Ni0wOSAyMzo0NTo0OS4wMDAwMDAwMDAgLTAzMDAKKysrIGIva2VybmVsL3NpZ25hbC5jICAgICAg IDIwMDgtMDYtMDkgMjM6NTI6MzYuMDAwMDAwMDAwIC0wMzAwCkBAIC0xMTIwLDcgKzExMjAsNyBA QAogICogaXMgcHJvYmFibHkgd3JvbmcuICBTaG91bGQgbWFrZSBpdCBsaWtlIEJTRCBvciBTWVNW LgogICovCgotc3RhdGljIGludCBraWxsX3NvbWV0aGlu...
Jun 11, 7:11 pm 2008
Jeff Kirsher
[PATCH 1/2] [UPDATED] ixgbe: add LRO support
Support for in-kernel LRO with the ability to enable/disable via ethtool based on comments from Ben Hutchings. Signed-off-by: Mallikarjuna R Chilakala <mallikarjuna.chilakala@intel.com> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com> Signed-off-by: PJ Waskiewicz <peter.p.waskiewicz.jr@intel.com> --- drivers/net/ixgbe/ixgbe.h | 9 +++ drivers/net/ixgbe/ixgbe_ethtool.c | 11 ++++ drivers/net/ixgbe/ixgbe_main.c | 111 ++++++++++++++++++++++++++++++----...
Jun 11, 6:14 pm 2008
Randy Dunlap
Re: [PATCH 1/2] [UPDATED] ixgbe: add LRO support
Is there also a patch to drivers/net/Kconfig that makes IXGBE depend on INET? --- ~Randy --
Jun 11, 6:20 pm 2008
Jeff Kirsher
[PATCH 2/2] MAINTAINERS
Add PJ Waskiewicz to the list of maintainers for Intel 10/100/1000/10GbE adapters. Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com> Signed-off-by: PJ Waskiewicz <peter.p.waskiewicz.jr@intel.com> --- MAINTAINERS | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index f5583dc..b87e0e2 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -2118,6 +2118,8 @@ P: Jesse Brandeburg M: jesse.brandeburg@intel.com P: Bruce Allan M: b...
Jun 11, 6:15 pm 2008
Alessandro Suardi
[2.6.26-rc5-git2] WARNING: at kernel/lockdep.c:2658 check_fl...
Recently upgraded my FC6 desktop to Fedora 9; with the latest nautilus RPM updates my VNC session went nuts with nautilus pegging the CPU for everything that breathed. I now reverted to an earlier nautilus package, but during the peak CPU period my kernel spat this: [314185.623294] ------------[ cut here ]------------ [314185.623414] WARNING: at kernel/lockdep.c:2658 check_flags+0x4c/0x128() [314185.623514] Modules linked in: iptable_filter ip_tables x_tables sunrpc ipv6 fuse snd_via82xx snd_...
Jun 11, 6:06 pm 2008
Malte Cornils
Lenovo ThinkCentre A55: parport_pc 00:0a: disabled; probe o...
Hello LKML readers, a friend of mine is unable to print on her system. I could trace that to the kernel not finding the parallel port on the system. Windows Vista, for whatever that's worth, prints fine. dmesg says: [ 40.935843] parport_pc 00:0a: disabled [ 40.935850] parport_pc: probe of 00:0a failed with error -22 rmmod parport_pc ; modprobe parport_pc io=0x378 irq=none did not work either, the detection failed and echoing some bytes to the /dev/lp0 device fails, too. Booting with no...
Jun 11, 5:52 pm 2008
Malte Cornils
Re: Lenovo ThinkCentre A55: parport_pc 00:0a: disabled; pro...
Hello again, attempting this, dmesg displays: [ 687.741109] parport 0x378 (WARNING): CTR: wrote 0x0c, read 0xff [ 687.741119] parport 0x378 (WARNING): DATA: wrote 0xaa, read 0xff [ 687.741122] parport 0x378: You gave this address, but there is probably no parallel port there! [ 687.741144] parport0: PC-style at 0x378 [PCSPP,TRISTATE] [ 687.838463] lp0: using parport0 (polling). cat /sys/devices/pnp0/00:0a/resources shows the resource as disabled. Even after echo "auto" > ..resources...
Jun 11, 6:27 pm 2008
Alexander Beregalov
Re: 2.6.26-rc1: possible circular locking dependency
I have bisected it and it seems introduced here: How could it be? 54a6eb5c4765aa573a030ceeba2c14e3d2ea5706 is first bad commit commit 54a6eb5c4765aa573a030ceeba2c14e3d2ea5706 Author: Mel Gorman <mel@csn.ul.ie> Date: Mon Apr 28 02:12:16 2008 -0700 mm: use two zonelist that are filtered by GFP mask Currently a node has two sets of zonelists, one for each zone type in the system and a second set for GFP_THISNODE allocations. Based on the zones allowed by a gfp mask, one ...
Jun 11, 5:18 pm 2008
Daniel Walker
[PATCH 4/5] rtmutex: add generic blocked_on usage
Modify the rtmutex to use the generic blocked_on field. Signed-off-by: Daniel Walker <dwalker@mvista.com> --- include/linux/sched.h | 4 ++-- kernel/fork.c | 1 - kernel/rtmutex.c | 35 ++++++++++++++++++++++++----------- 3 files changed, 26 insertions(+), 14 deletions(-) Index: linux-2.6.25/include/linux/sched.h =================================================================== --- linux-2.6.25.orig/include/linux/sched.h +++ linux-2.6.25/include/linux/sched.h @...
Jun 11, 4:49 pm 2008
Daniel Walker
[PATCH 3/5] mutex debug: add generic blocked_on usage
There are a couple of blocked on type structures. One for mutexes, and one for rtmutexes, and we also need one for futexes. Instead of just adding another one to the task struct I combined them all into a union. Since a waiter can only be blocked on one of the types at any given time this should be safe. I also usurped the pi_lock as the lock which protects all the blocked_on types. Signed-off-by: Daniel Walker <dwalker@mvista.com> --- include/linux/sched.h | 36 ++++++++++++++++++++...
Jun 11, 4:49 pm 2008
Daniel Walker
[PATCH 5/5] futex: fix miss ordered wakeups
Adds an additional function call to the sched_setscheduler to update the waiter position of a task if it happens to be waiting on a futex. This ensures that the kernel level waiter ordering is correctly maintained based on the changed priority of the task. I fixed the locking issue noticed by Thomas Gleixner. This doesn't address userspace at all, only the kernel level wakeups and kernel level ordering. The additional locking added to the futex_wait function has no visible speed impact, and on...
Jun 11, 4:49 pm 2008
Daniel Walker
[PATCH 2/5] futex: update prio on requeue
Since the priority may have changed, the requeue is a good place to update the priority since we're already deleting and adding to a new list. Signed-off-by: Daniel Walker <dwalker@mvista.com> --- kernel/futex.c | 3 +++ 1 file changed, 3 insertions(+) Index: linux-2.6.25/kernel/futex.c =================================================================== --- linux-2.6.25.orig/kernel/futex.c +++ linux-2.6.25/kernel/futex.c @@ -980,7 +980,10 @@ static int futex_requeue(u32 __user *uad...
Jun 11, 4:49 pm 2008
Daniel Walker
[PATCH 1/5] futex: checkpatch cleanup
Signed-off-by: Daniel Walker <dwalker@mvista.com> --- kernel/futex.c | 52 +++++++++++++++++++++++++++------------------------- 1 file changed, 27 insertions(+), 25 deletions(-) Index: linux-2.6.25/kernel/futex.c =================================================================== --- linux-2.6.25.orig/kernel/futex.c +++ linux-2.6.25/kernel/futex.c @@ -145,7 +145,7 @@ static inline void futex_unlock_mm(struc */ static struct futex_hash_bucket *hash_futex(union futex_key *key) { -...
Jun 11, 4:49 pm 2008
Paul Menage
[PATCH] Fix 32-bit truncation of segment sizes in /proc/sysv...
sysvipc_shm_proc_show() picks between format strings (based on the expected maximum length of a SHM segment) in a way that prevents gcc from performing format checks on the seq_printf() parameters. This hid two format errors - shp->shm_segsz and shp->shm_nattach are both unsigned long, but were being printed as unsigned int and signed int respectively. This leads to 32-bit truncation of SHM segment sizes reported in /proc/sysvipc/shm. (And for nattach, but that's less of a problem for most us...
Jun 11, 4:30 pm 2008
Bartlomiej Zolnierki...
[PATCH 6/6] opti621: add PIO 4 support
* Add PIO 4 support. While at it: * Use a single struct ide_port_info instance for OPTi621 and OPTi621X. Based on a bugreport from Juergen Kosel & inspired by pata_opti.c code. Tested-by: Juergen Kosel <juergen.kosel@gmx.de> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> --- drivers/ide/pci/opti621.c | 46 ++++++++++++++-------------------------------- 1 file changed, 14 insertions(+), 32 deletions(-) Index: b/drivers/ide/pci/opti621.c ==================...
Jun 11, 4:01 pm 2008
Bartlomiej Zolnierki...
[PATCH 5/6] opti621: use pre-calculated PIO timings
* Use pre-calculated PIO timings in ->set_pio_mode. * Remove no longer needed compute_clocks(), cmpt_clk(), struct pio_clocks_s, PIO_* defines and OPTI621_DEBUG define. There should be no functional changes caused by this patch. Based on a bugreport from Juergen Kosel & inspired by pata_opti.c code. Tested-by: Juergen Kosel <juergen.kosel@gmx.de> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> --- drivers/ide/pci/opti621.c | 92 +++++++-------------------...
Jun 11, 4:00 pm 2008
Bartlomiej Zolnierki...
[PATCH 4/6] opti621: program devices timings separately in -...
* Set drive->drive_data to 'pio + XFER_PIO_0' instead of 'pio', then simplify selecting maximum adress setup timing. * Remove no longer needed compute_pios() and opti621_port_init_devs(). * Program devices timings separately in ->set_pio_mode. Based on a bugreport from Juergen Kosel & inspired by pata_opti.c code. Tested-by: Juergen Kosel <juergen.kosel@gmx.de> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> --- drivers/ide/pci/opti621.c | 80 ++++++++...
Jun 11, 3:59 pm 2008
Bartlomiej Zolnierki...
[PATCH 3/6] opti621: use PCI clock value provided by control...
Use PCI clock value provided by controller instead of depending on a default (or user supplied) value. Based on a bugreport from Juergen Kosel & inspired by pata_opti.c code. Tested-by: Juergen Kosel <juergen.kosel@gmx.de> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> --- drivers/ide/pci/opti621.c | 42 ++++++++++++++++++++++-------------------- 1 file changed, 22 insertions(+), 20 deletions(-) Index: b/drivers/ide/pci/opti621.c =============================...
Jun 11, 3:59 pm 2008
Bartlomiej Zolnierki...
[PATCH 1/6] opti621: disable read prefetch
This fixes 2.6.25 regression (kernel.org bugzilla bug #10723) caused by: commit 912fb29a36a7269ac1c4a4df45bc0ac1d2637972 Author: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> Date: Fri Oct 19 00:30:11 2007 +0200 opti621: always tune PIO ... Based on a bugreport from Juergen Kosel & inspired by pata_opti.c code. Bisected-by: Juergen Kosel <juergen.kosel@gmx.de> Tested-by: Juergen Kosel <juergen.kosel@gmx.de> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@g...
Jun 11, 3:57 pm 2008
Bartlomiej Zolnierki...
[PATCH 2/6] opti621: remove DMA support
These controllers don't support DMA. Based on a bugreport from Juergen Kosel & inspired by pata_opti.c code. Tested-by: Juergen Kosel <juergen.kosel@gmx.de> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> --- drivers/ide/pci/opti621.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) Index: b/drivers/ide/pci/opti621.c =================================================================== --- a/drivers/ide/pci/opti621.c +++ b/drivers/ide/pci/opti621....
Jun 11, 3:58 pm 2008
Sergei Shtylyov
Re: [PATCH 2/6] opti621: remove DMA support
Hello. Verily. I have the 82C621A datasheet. Acked-by: Sergei Shtylyov <sshtylyov@ru.mvista.com> MBR, Sergei --
Jun 11, 6:10 pm 2008
Bartlomiej Zolnierki...
[PATCH 5/5] sgiioc4: call ide_find_port_slot() later
Move ide_find_port_slot() call closer to ide_device_add(). This is basically a preparation for the future changes. Cc: Jeremy Higdon <jeremy@sgi.com> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> --- drivers/ide/pci/sgiioc4.c | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) Index: b/drivers/ide/pci/sgiioc4.c =================================================================== --- a/drivers/ide/pci/sgiioc4.c +++ b/drivers/ide/pci/sgiioc4.c @@ ...
Jun 11, 3:22 pm 2008
Bartlomiej Zolnierki...
[PATCH 3/5] icside: always try to probe first interface
Try to probe first interface even if ide_hwifs[]'s slot for the second interface cannot be obtained. While at it: - Add DRV_NAME define and use it for request_dma() instead of hwif->name. Cc: Russell King <rmk@arm.linux.org.uk> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> --- drivers/ide/arm/icside.c | 18 ++++++++++-------- 1 file changed, 10 insertions(+), 8 deletions(-) Index: b/drivers/ide/arm/icside.c =================================================...
Jun 11, 3:20 pm 2008
Bartlomiej Zolnierki...
[PATCH 2/5] rapide: fix rapide_probe() return value
Return -ENOENT on ide_find_port() failure. While at it: - Cleanup rapide_probe() a bit. Cc: Russell King <rmk@arm.linux.org.uk> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> --- drivers/ide/arm/rapide.c | 28 +++++++++++++++------------- 1 file changed, 15 insertions(+), 13 deletions(-) Index: b/drivers/ide/arm/rapide.c =================================================================== --- a/drivers/ide/arm/rapide.c +++ b/drivers/ide/arm/rapide.c @@ -48,24...
Jun 11, 3:19 pm 2008
Bartlomiej Zolnierki...
[PATCH 1/5] ide-cs: fix probing and add warm-plug support
* Fix probing by using ide_port_scan() and moving "retry loop" from ide_config() to idecs_register(). * Don't fail probe if there are no devices attached to a port. * Remove (now redundant) error message from ide_config(). Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> --- drivers/ide/legacy/ide-cs.c | 37 +++++++++++++++---------------------- 1 file changed, 15 insertions(+), 22 deletions(-) Index: b/drivers/ide/legacy/ide-cs.c ====================================...
Jun 11, 3:18 pm 2008
Rafael Almeida
Re: [PATCH] Fixed NetEm's reorder option
I noticed no one said anything about my patch below, did I do something terrible wrong? Should I just be more patient? On Thu, Jun 5, 2008 at 1:34 AM, Rafael C. de Almeida --
Jun 11, 4:05 pm 2008
Stephen Hemminger
Re: [PATCH] Fixed NetEm's reorder option
On Wed, 11 Jun 2008 17:05:10 -0300 Haven't had time to look at this in detail, and I worry about the impact of changing assumptions people already have in their scripts. --
Jun 11, 5:49 pm 2008
J. Bruce Fields
CONFIG_DEBUG_SLAB_LEAK omits size-4096 and larger?
I'm probably missing something fundamental--why doesn't /proc/slab_allocators show any results for size-x where x >= 4096? Someone's seeing a performance problem with the linux nfs server. One of the symptoms is the "size-4096" slab cache seems to be out of control. I assumed that meant that memory allocated by kmalloc() might be leaking, so figured it might be interesting to turn on CONFIG_DEBUG_SLAB_LEAK. As far as I can tell what that does is list kmalloc() callers in /proc/slab_allocators...
Jun 11, 3:52 pm 2008
Jeff Layton
Re: CONFIG_DEBUG_SLAB_LEAK omits size-4096 and larger?
On Wed, 11 Jun 2008 15:52:22 -0400 Hmm...I've never used this, but in kmem_cache_alloc(): /* * Enable redzoning and last user accounting, except for caches with * large objects, if the increased size would increase the object size * above the next power of two: caches with object sizes just above a * power of two have a significant amount of internal fragmentation. */ if (size < 4096 || fls(size - 1) == fls(size-1 + REDZONE_ALIGN ...
Jun 11, 4:09 pm 2008
J. Bruce Fields
Re: CONFIG_DEBUG_SLAB_LEAK omits size-4096 and larger?
Ah, I missed that! I'm a little confused as to how those flags behavior affect the collection of the leak debugging data, but I can verify that the below does result in size-4096 showing up in /proc/slab_allocators; hopefully there's no more negative result than the performance penalty. Norman, do you think you could try applying this and then trying again? --b. diff --git a/mm/slab.c b/mm/slab.c index 06236e4..b379e31 100644 --- a/mm/slab.c +++ b/mm/slab.c @@ -2202,7 +2202,7 @@ kmem_ca...
Jun 11, 4:57 pm 2008
Weathers, Norman R.
RE: CONFIG_DEBUG_SLAB_LEAK omits size-4096 and larger?
I will try and get it patched and retested, but it may be a day or two before I can get back the information due to production jobs now running. Once they finish up, I will get back with the info. Norman Weathers --
Jun 11, 6:46 pm 2008
J. Bruce Fields
Re: CONFIG_DEBUG_SLAB_LEAK omits size-4096 and larger?
And thanks for your persistence. --
Jun 11, 6:54 pm 2008
ndyhojdhyovf
頭條大新聞~!好康超值!!‧多款 迷人洋裝只要$...
流行女裝 ‧ 進 口 服 飾 批 發 jorge 洋裝120元 上衣35元 上網搜尋→ may.shop 即可找到批發站 零售買家 請至→http://tw.user.bid.yahoo.com/tw/booth/may26tw 一元搶標喔!! z --
Jun 11, 2:48 pm 2008
Mark Fasheh
Re: [Ocfs2-devel] [PATCH 1/1] ocfs2/net: Silence build warni...
Hmm, this seems to have fallen through the cracks. It's in ocfs2.git now though. --Mark -- Mark Fasheh --
Jun 11, 2:50 pm 2008
Rik van Riel
[PATCH -mm 24/24] doc: unevictable LRU and mlocked pages doc...
From: Lee Schermerhorn <lee.schermerhorn@hp.com> Documentation for unevictable lru list and its usage. Signed-off-by: Lee Schermerhorn <lee.schermerhorn@hp.com> Signed-off-by: Rik van Riel <riel@redhat.com> --- Documentation/vm/unevictable-lru.txt | 609 +++++++++++++++++++++++++++++++++++ 1 file changed, 609 insertions(+) Index: linux-2.6.26-rc5-mm2/Documentation/vm/unevictable-lru.txt =================================================================== --- /dev/null 1...
Jun 11, 2:42 pm 2008
Rik van Riel
[PATCH -mm 16/24] mlock: mlocked pages are unevictable
From: Nick Piggin <npiggin@suse.de> Make sure that mlocked pages also live on the unevictable LRU, so kswapd will not scan them over and over again. This is achieved through various strategies: 1) add yet another page flag--PG_mlocked--to indicate that the page is locked for efficient testing in vmscan and, optionally, fault path. This allows early culling of unevictable pages, preventing them from getting to page_referenced()/try_to_unmap(). Also allows separate accoun...
Jun 11, 2:42 pm 2008
Rik van Riel
[PATCH -mm 18/24] mmap: handle mlocked pages during map, rem...
Originally From: Nick Piggin <npiggin@suse.de> Remove mlocked pages from the LRU using "unevictable infrastructure" during mmap(), munmap(), mremap() and truncate(). Try to move back to normal LRU lists on munmap() when last mlocked mapping removed. Remove PageMlocked() status when page truncated from file. Signed-off-by: Nick Piggin <npiggin@suse.de> Signed-off-by: Lee Schermerhorn <lee.schermerhorn@hp.com> Signed-off-by: Rik van Riel <riel@redhat.com> Signed-off-by: K...
Jun 11, 2:42 pm 2008
Rik van Riel
[PATCH -mm 20/24] swap: cull unevictable pages in fault path
From: Lee Schermerhorn <lee.schermerhorn@hp.com> In the fault paths that install new anonymous pages, check whether the page is evictable or not using lru_cache_add_active_or_unevictable(). If the page is evictable, just add it to the active lru list [via the pagevec cache], else add it to the unevictable list. This "proactive" culling in the fault path mimics the handling of mlocked pages in Nick Piggin's series to keep mlocked pages off the lru lists. Notes: 1) This patch is optio...
Jun 11, 2:42 pm 2008
Rik van Riel
[PATCH -mm 23/24] mlock: count attempts to free mlocked page
From: Lee Schermerhorn <lee.schermerhorn@hp.com> Allow free of mlock()ed pages. This shouldn't happen, but during developement, it occasionally did. This patch allows us to survive that condition, while keeping the statistics and events correct for debug. Signed-off-by: Lee Schermerhorn <lee.schermerhorn@hp.com> Signed-off-by: Rik van Riel <riel@redhat.com> --- include/linux/vmstat.h | 1 + mm/internal.h | 17 +++++++++++++++++ mm/page_alloc.c ...
Jun 11, 2:42 pm 2008
Rik van Riel
[PATCH -mm 11/24] pageflag helpers for configed-out flags
From: Lee Schermerhorn <lee.schermerhorn@hp.com> Define proper false/noop inline functions for noreclaim page flags when !defined(CONFIG_NORECLAIM_LRU) Signed-off-by: Lee Schermerhorn <lee.schermerhorn@hp.com> Signed-off-by: Rik van Riel <riel@redhat.com> --- include/linux/page-flags.h | 12 ++++++++++++ 1 file changed, 12 insertions(+) Index: linux-2.6.26-rc5-mm2/include/linux/page-flags.h =================================================================== --- linux-2...
Jun 11, 2:42 pm 2008
Andrew Morton
Re: [PATCH -mm 11/24] pageflag helpers for configed-out flags
On Wed, 11 Jun 2008 14:42:25 -0400 I changed that to CONFIG_UNEVICTABLE_LRU. Did we agree that the presence of this config variable is undesirable? If so, what's involved in making it go away? --
Jun 11, 4:01 pm 2008
Lee Schermerhorn
Re: [PATCH -mm 11/24] pageflag helpers for configed-out flags
I noticed that the vmstat items [perhaps these will go away] still use Not sure we did. It does add quite a bit of code that probably wouldn't be needed/wanted for, say, a laptop system or other small systems that still have an mmu. I initially made it configurable keeping in mind your speeches about not burdening smaller systems with larger system Just some busy work. I added a fair number of wrappers and such to minimize #ifdefs in the .c files. This resulted in quite a few such #ifdefs i...
Jun 11, 4:28 pm 2008
Rik van Riel
Re: [PATCH -mm 11/24] pageflag helpers for configed-out flags
On Wed, 11 Jun 2008 16:28:03 -0400 $ cat /proc/vmstat nr_free_pages 3887198 nr_inactive_anon 5043 nr_active_anon 2182 nr_inactive_file 67121 nr_active_file 49045 nr_unevictable 0 nr_mlock 0 Or am I looking at the wrong thing? -- All rights reversed. --
Jun 11, 4:32 pm 2008
Lee Schermerhorn
Re: [PATCH -mm 11/24] pageflag helpers for configed-out flags
Do you have patch 21/24 applied? In 26-rc5-mm1, I see the noreclaim_pgs_* vmstat items. They're in the patch 21 you just posted, as well. Again, we might decide to drop that patch from the merge. I found the stats useful during debug and test, but I don't know that they provide any value in the longer term. Lee --
Jun 11, 4:43 pm 2008
Rik van Riel
Re: [PATCH -mm 11/24] pageflag helpers for configed-out flags
On Wed, 11 Jun 2008 16:43:01 -0400 Doh! I am working against: http://userweb.kernel.org/~akpm/mmotm/ You may want to send Andrew an update against patch 21/24 that That's an option too. I'll let you and Kosaki-san decide on that, since I had relatively little involvement with the second half of the patch series recently. -- All rights reversed. --
Jun 11, 4:48 pm 2008
Rik van Riel
Re: [PATCH -mm 11/24] pageflag helpers for configed-out flags
On Wed, 11 Jun 2008 13:01:45 -0700 We agreed that having CONFIG_NORELAIM_SWAP was bad, that one went away. As for CONFIG_UNEVICTABLE_LRU, I believe we will want to at least give embedded people the option to compile without all that code, similar to CONFIG_SWAP. -- All rights reversed. --
Jun 11, 4:08 pm 2008
previous daytodaynext day
June 10, 2008June 11, 2008June 12, 2008