[PATCH -mm] mm/shmem.c: ret can be used uninitialized

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: lkml <linux-kernel@...>
Cc: Andrew Morton <akpm@...>
Date: Wednesday, June 11, 2008 - 3:37 pm

From 6c4eb2ce2849308c4a745ec1f93001e5064a469c Mon Sep 17 00:00:00 2001
From: Serge Hallyn <serge@us.ibm.com>
Date: Wed, 11 Jun 2008 11:20:28 -0500
Subject: [PATCH -mm] mm/shmem.c: ret can be used uninitialized

Make sure ret is defined before check at line 1408.

Signed-off-by: Serge Hallyn <serge@us.ibm.com>
---
 mm/shmem.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/mm/shmem.c b/mm/shmem.c
index ad24be7..b326ff2 100644
--- a/mm/shmem.c
+++ b/mm/shmem.c
@@ -1365,7 +1365,7 @@ repeat:
 		}
 
 		if (!filepage) {
-			int ret;
+			int ret = 0;
 
 			spin_unlock(&info->lock);
 			filepage = shmem_alloc_page(gfp, info, idx);
-- 
1.5.4.3

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH -mm] mm/shmem.c: ret can be used uninitialized, Serge E. Hallyn, (Wed Jun 11, 3:37 pm)
Re: [PATCH -mm] mm/shmem.c: ret can be used uninitialized, Andrew Morton, (Wed Jun 11, 9:24 pm)
Re: [PATCH -mm] mm/shmem.c: ret can be used uninitialized, Serge E. Hallyn, (Thu Jun 12, 9:15 am)