Re: [PATCH -mm 11/24] pageflag helpers for configed-out flags

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Andrew Morton <akpm@...>
Cc: Rik van Riel <riel@...>, <linux-kernel@...>, <kosaki.motohiro@...>
Date: Wednesday, June 11, 2008 - 4:28 pm

On Wed, 2008-06-11 at 13:01 -0700, Andrew Morton wrote:

I noticed that the vmstat items [perhaps these will go away] still use
"noreclaim".


Not sure we did.  It does add quite a bit of code that probably wouldn't
be needed/wanted for, say, a laptop system or other small systems that
still have an mmu.  I initially made it configurable keeping in mind
your speeches about not burdening smaller systems with larger system
features, ...  


Just some busy work.  I added a fair number of wrappers and such to
minimize #ifdefs in the .c files.  This resulted in quite a few such
#ifdefs in the respective headers.   Removing these should mostly
involve removing the #ifdef and the #else case.  Most of them that
remain in .c files are for large blocks of code, mostly complete
functions, and can just be removed.

Let me know the consensus.  I can send in a patch to remove them if it's
agreed.  Might want to wait until we're sure that this is the only
barrier to merging, as the option might be useful during testing. 

Lee


--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Re: [PATCH -mm 11/24] pageflag helpers for configed-out flags, Lee Schermerhorn, (Wed Jun 11, 4:28 pm)
Re: [PATCH -mm 11/24] pageflag helpers for configed-out flags, Lee Schermerhorn, (Wed Jun 11, 4:43 pm)
Re: [PATCH -mm 11/24] pageflag helpers for configed-out flags, Lee Schermerhorn, (Wed Jun 11, 4:23 pm)