On Wednesday 11 June 2008, Jean Delvare wrote:
quoted text
> On Thu, 12 Jun 2008 08:13:09 +1200, Ryan Mallon wrote:
> >                               As David suggested, if i2c is needed early
> > in enough cases, why not just move it early in the link order? My patch
> > was just an alternative approach which mimics the current behaviour, but
> > makes it possible to get any i2c driver early. Why not just mark all of
> > the drivers/busses that get used on embedded devices as subsys_initcall,
> > just in case somebody needs them early?
> 
> Because this is an abuse of subsys_initcall? I guess that was
> acceptable when only a couple drivers were doing that, but making it
> official sounds bad.

How would it be an abuse?  On those systems, I2C is a "system bus"
and needs to be initialized early for the same reasons PCI gets set
up very early on PC hardware.

There's no rule saying that subsystem initialization may not include
the essential drivers -- in this case, i2c_adapter drivers.  PCI hubs
and bridges are certainly initialized very early, before module_init
code runs...

And in fact it seems a bit odd to think that initializing any bus
subsystem shouldn't be allowed to include its bus adapters.  It's
not as if the subsystem has completed initializiation until those
adapters are usable!!

- Dave

--
unsubscribe notice
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/