drivers/net/smc91x.c fails as follows on blackfin:

<--  snip  -->

...
  CC      drivers/net/smc91x.o
...
/home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/net/smc91x.c:1863:36: error: macro "SMC_GET_MAC_ADDR" passed 2 arguments, but takes just 1
...
make[3]: *** [drivers/net/smc91x.o] Error 1

<--  snip  -->

The required action seems to be a revert of:
commit 099c736a470c8080a166e7a089f1e48e15f9947c
(Revert "smc91x: fix build breakage from the SMC_GET_MAC_ADDR API upgrade") (sic).

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

--

[ message continues ]

it's a known issue (been known for quite a long time actually).  Bryan
has brought this up in the past already.
-mike
--

[ message continues ]

Is my suggestion of reverting commit 099c736a470c8080a166e7a089f1e48e15f9947c
correct or how else should it be resolved?

This issue is the only remaining problem preventing that all blackfin 

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

--

[ message continues ]

Bryan is taking care of it ... it may just stay broken in favor of

not really true.  but otherwise, failures dont go unnoticed as we have
automated nightly builds for all the relevant trees.
-mike
--

[ message continues ]

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

--

[ message continues ]

Sorry for jumping in later. I reported this issue 2 months ago.
http://lkml.org/lkml/2008/4/7/38

And Adrian is right, we need to revert this patch.

Linus, could you please revert it?
099c736a470c8080a166e7a089f1e48e15f9947c
Or I send a patch out to revert it?

Thanks
-Bryan
--

[ message continues ]

Oh, sorry for the confusing. we need to recommit the patch to fix this
build breakage.
9e6db60825ef7e7999abc610ce256ba768e58162
"smc91x: fix build breakage from the SMC_GET_MAC_ADDR API upgrade"

Jeff, do you have my this patch in your tree or just we revert the
099c736a470c8080a166e7a089f1e48e15f9947c?

Thanks
-Bryan
--

[ message continues ]

I'd like to see a patch, since by now I'm confused by this all whether 
it's a straight revert or if there's a fix.

			Linus
--

[ message continues ]

On Wed, Jun 11, 2008 at 11:47 AM, Linus Torvalds

No problem, I will send a patch soon.

-Bryan
--

[ message continues ]