Home » Mailing list archives » linux-kernel » 2008 » June » 10

[PATCH 11/14] ide: remove superfluous BUG_ON() from set_geometry_intr()

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Bartlomiej Zolnierkiewicz
Subject: [PATCH 11/14] ide: remove superfluous BUG_ON() from set_geometry_intr()
Date: Tuesday, June 10, 2008 - 1:52 pm

ide_set_handler() bugs on ->handler == NULL so no need to do it
in set_geometry_intr().

There should be no functional changes caused by this patch.

Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
---
 drivers/ide/ide-taskfile.c |    1 -
 1 file changed, 1 deletion(-)

Index: b/drivers/ide/ide-taskfile.c
===================================================================
--- a/drivers/ide/ide-taskfile.c
+++ b/drivers/ide/ide-taskfile.c
@@ -163,7 +163,6 @@ static ide_startstop_t set_geometry_intr
 	if (stat & (ERR_STAT|DRQ_STAT))
 		return ide_error(drive, "set_geometry_intr", stat);
 
-	BUG_ON(HWGROUP(drive)->handler != NULL);
 	ide_set_handler(drive, &set_geometry_intr, WAIT_WORSTCASE, NULL);
 	return ide_started;
 }
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH 01/14] cmd640: fix warm-plug support for the second ..., Bartlomiej Zolnierki ..., (Tue Jun 10, 1:50 pm)
[PATCH 02/14] ide: -&gt;port_init_devs -&gt; -&gt;init_dev, Bartlomiej Zolnierki ..., (Tue Jun 10, 1:51 pm)
[PATCH 03/14] cmd640: add -&gt;init_dev method, Bartlomiej Zolnierki ..., (Tue Jun 10, 1:51 pm)
[PATCH 04/14] rapide: use struct ide_port_info, Bartlomiej Zolnierki ..., (Tue Jun 10, 1:51 pm)
[PATCH 05/14] ide-h8300: use struct ide_port_info, Bartlomiej Zolnierki ..., (Tue Jun 10, 1:51 pm)
[PATCH 06/14] ide_platform: use struct ide_port_info, Bartlomiej Zolnierki ..., (Tue Jun 10, 1:51 pm)
[PATCH 07/14] ide: print message on error in ide_find_port ..., Bartlomiej Zolnierki ..., (Tue Jun 10, 1:51 pm)
[PATCH 08/14] ide-h8300: print driver banner message early, Bartlomiej Zolnierki ..., (Tue Jun 10, 1:52 pm)
[PATCH 09/14] ide-pnp: print driver banner message early, Bartlomiej Zolnierki ..., (Tue Jun 10, 1:52 pm)
[PATCH 10/14] ide: allow any command requesting DMA data p ..., Bartlomiej Zolnierki ..., (Tue Jun 10, 1:52 pm)
[PATCH 11/14] ide: remove superfluous BUG_ON() from set_ge ..., Bartlomiej Zolnierki ..., (Tue Jun 10, 1:52 pm)
[PATCH 12/14] ide: remove needless includes from ide.c, Bartlomiej Zolnierki ..., (Tue Jun 10, 1:52 pm)
[PATCH 13/14] ide: remove needless includes from ide-taskf ..., Bartlomiej Zolnierki ..., (Tue Jun 10, 1:52 pm)
[PATCH 14/14] ide: remove needless includes from setup-pci.c, Bartlomiej Zolnierki ..., (Tue Jun 10, 1:53 pm)