Re: [PATCH 0 of 7] Block/SCSI Data Integrity Support

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Martin K. Petersen <martin.petersen@...>
Cc: <linux-kernel@...>, <linux-scsi@...>
Date: Tuesday, June 10, 2008 - 10:41 am

"Martin K. Petersen" <martin.petersen@oracle.com> writes:


Pointers to archives would have been appreciated.  I can't, for the life
of me, find these.


Thanks for all of the great documentation.  It would be good to include
some instructions on how one would test this, and what testing you
performed.  Also, please use the '-p' switch to diff, as it makes
reviewing patches much easier.

I set out to try your changes, but ran into some problems.  First, this
patch set didn't apply cleanly to a git checkout.  So, I grabbed your
mercurial repository, but got a build failure:

block/blk-core.c: In function 'generic_make_request':
include/linux/bio.h:469: sorry, unimplemented: inlining failed in call to 'bio_i
ntegrity_enabled': function body not available
block/blk-core.c:1388: sorry, unimplemented: called from here
make[1]: *** [block/blk-core.o] Error 1
make: *** [block] Error 2

Cheers,

Jeff
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH 0 of 7] Block/SCSI Data Integrity Support, Martin K. Petersen, (Sat Jun 7, 12:55 am)
Re: [PATCH 0 of 7] Block/SCSI Data Integrity Support, Jeff Moyer, (Tue Jun 10, 10:41 am)
Re: [PATCH 0 of 7] Block/SCSI Data Integrity Support, Martin K. Petersen, (Tue Jun 10, 11:28 am)
Re: [PATCH 0 of 7] Block/SCSI Data Integrity Support, Mike Snitzer, (Thu Jul 17, 9:55 am)
Re: [PATCH 0 of 7] Block/SCSI Data Integrity Support, Martin K. Petersen, (Thu Jul 17, 11:35 am)
Re: [PATCH 0 of 7] Block/SCSI Data Integrity Support, Jeff Moyer, (Tue Jun 10, 2:49 pm)
Re: [PATCH 0 of 7] Block/SCSI Data Integrity Support, Martin K. Petersen, (Tue Jun 10, 4:47 pm)
Re: [PATCH 0 of 7] Block/SCSI Data Integrity Support, Jeff Moyer, (Tue Jun 10, 4:53 pm)
[PATCH 7 of 7] Support for SCSI disk (SBC) Data Integrity Fi..., Martin K. Petersen, (Sat Jun 7, 12:55 am)
[PATCH 5 of 7] block: Block/request layer data integrity sup..., Martin K. Petersen, (Sat Jun 7, 12:55 am)
Re: [PATCH 5 of 7] block: Block/request layer data integrity..., Martin K. Petersen, (Mon Jun 9, 11:06 am)
[PATCH 4 of 7] block: bio data integrity support, Martin K. Petersen, (Sat Jun 7, 12:55 am)
Re: [PATCH 4 of 7] block: bio data integrity support, Jeff Moyer, (Tue Jun 10, 4:52 pm)
Re: [PATCH 4 of 7] block: bio data integrity support, Martin K. Petersen, (Wed Jun 11, 12:05 am)
Re: [PATCH 4 of 7] block: bio data integrity support, Jeff Moyer, (Wed Jun 11, 1:41 pm)
Re: [PATCH 4 of 7] block: bio data integrity support, Monakhov Dmitri, (Sat Jun 7, 10:45 am)
Re: [PATCH 4 of 7] block: bio data integrity support, Martin K. Petersen, (Mon Jun 9, 11:05 am)
[PATCH 6 of 7] scsi: Support devices with protection informa..., Martin K. Petersen, (Sat Jun 7, 12:55 am)
[PATCH 1 of 7] lib: Add support for the T10 Data Integrity F..., Martin K. Petersen, (Sat Jun 7, 12:55 am)
[PATCH 2 of 7] block: Globalize bio_set and bio_vec_slab, Martin K. Petersen, (Sat Jun 7, 12:55 am)
[PATCH 3 of 7] block: Find bio sector offset given idx and o..., Martin K. Petersen, (Sat Jun 7, 12:55 am)
Re: [PATCH 3 of 7] block: Find bio sector offset given idx a..., Martin K. Petersen, (Mon Jun 9, 12:15 pm)