Re: [patch 11/11] GRU Driver - makefile & Kconfig file changes

view
thread

!MAILaRCHIVE_VOTE_RePLACE

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

[view in full thread]

From: Jack Steiner <steiner@...>

To: Roland Dreier <rdreier@...>

Cc: <akpm@...>, <linux-kernel@...>, <mingo@...>, <tglx@...>, <holt@...>, <andrea@...>

Subject: Re: [patch 11/11] GRU Driver - makefile & Kconfig file changes

Date: Tuesday, June 10, 2008 - 10:41 am

On Mon, Jun 09, 2008 at 02:35:09PM -0700, Roland Dreier wrote:
quoted text>  > +EXTRA_CFLAGS += -DDEBUG -Werror -Wall
> 
> Not sure if it's appropriate to set these flags for your driver...

Deleted. This was primarily for debugging. I moved the DEBUG option to
Kconfig as a driver DEBUG option that can be selected.


quoted text> 
>  > +	---help---
>  > +	This option enables basic support for the SGI UV GRU driver. If
>  > +	you are not running on a SGI UV system, say N.
> 
> "...enables basic support for the SGI UV GRU."  And it would be a good
> idea to include some info about what UV GRU does -- your 0/11
> introduction mail had a good description that would be nice to have here
> as well.

Done


--- jack
--
unsubscribe noticeTo unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:

[patch 11/11] GRU Driver - makefile & Kconfig file changes, , (Mon Jun 9, 5:10 pm)

Re: [patch 11/11] GRU Driver - makefile & Kconfig file changes, Roland Dreier, (Mon Jun 9, 5:35 pm)

Re: [patch 11/11] GRU Driver - makefile & Kconfig file changes, Jack Steiner, (Tue Jun 10, 10:41 am)

Navigation

Popular discussions


linux-kernel:
Tarkan Erimer	Re: Dual-Licensing Linux Kernel with GPL V2 and GPL V3
Greg KH	[GIT PATCH] driver core patches against 2.6.24
clameter	[31/36] Large Blocksize: Core piece
David Woodhouse	Re: [GIT *] Allow request_firmware() to be satisfied from in-kernel, use it in mor...
git:

linux-netdev:

Gerrit Renker	[PATCH 27/37] dccp: Integration of dynamic feature activation - part 2 (server side)
KOSAKI Motohiro	[bug?] tg3: Failed to load firmware "tigon/tg3_tso.bin"
Jarek Poplawski	[PATCH] pkt_sched: Destroy gen estimators under rtnl_lock().
openbsd-misc:

Colocation donated by:

Online users

Syndicate