On Fri, May 23, 2008 at 05:52:44PM -0500, James Bottomley wrote:
quoted text
> On Fri, 2008-05-23 at 15:39 -0700, Randy Dunlap wrote:
> > On Fri, 23 May 2008 17:00:30 -0500 James Bottomley wrote:
> > >      1. No stubs and simply select FW_LOADER for everything
> > >      2. Stubs that actually work in all situations.
> > > 
> > > My patch does 2.  I can see an argument for 1. but since we have the
> > > stubs, making them work in all cases seems like the smaller change to
> > > functionality.
> > 
> > Oh, I'm for the stubs approach.
> > 
> > So with SCSI_SAS_LIBSAS=y and FW_LOADER=m, you would want/expect
> > request_firmware() to return -EINVAL all of the time?
> 
> If you want stubs, yes
>...

I think I was the only one who had doubts about this patch.

And I've turned into a fan of your patch (plus my
"always enable FW_LOADER unless EMBEDDED=y" patch).

Can you (re)submit your patch so that it gets into 2.6.26?

quoted text
> James

Thanks
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

--
unsubscribe notice
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/