Re: [PATCH][resubmit] x86: enable preemption in delay

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Marin Mitov <mitov@...>
Cc: LKML <linux-kernel@...>, Steven Rostedt <rostedt@...>, Thomas Gleixner <tglx@...>, linux-rt-users <linux-rt-users@...>, <akpm@...>, Ingo Molnar <mingo@...>, Clark Williams <clark.williams@...>, Peter Zijlstra <peterz@...>, Luis Claudio R. Goncalves <lclaudio@...>, Gregory Haskins <ghaskins@...>, Linus Torvalds <torvalds@...>, Andi Kleen <andi-suse@...>
Date: Sunday, June 1, 2008 - 12:25 pm

>  static void delay_tsc(unsigned long loops)


The unsigneds should be probably u64  and the rdtsc rdtscll.
Otherwise this will all overflow for longer waits on a very
fast systems (e.g. a 5Ghz system wraps 32bit in ~1.1 seconds)
Normally such delays shouldn't be that long, but why risk
overflow even in extreme cases?

-Andi
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Re:[PATCH -v4] x86: enable preemption in delay, Marin Mitov, (Sun May 25, 2:08 pm)
Re:[PATCH -v4] x86: enable preemption in delay, Thomas Gleixner, (Sun May 25, 6:21 pm)
[PATCH][resubmit] x86: enable preemption in delay, Marin Mitov, (Sun Jun 1, 12:01 pm)
Re: [PATCH][resubmit] x86: enable preemption in delay, Marin Mitov, (Mon Jun 9, 12:11 pm)
Re: [PATCH][resubmit] x86: enable preemption in delay, Ingo Molnar, (Mon Jun 9, 12:16 pm)
Re: [PATCH][resubmit] x86: enable preemption in delay, Marin Mitov, (Sun Jun 15, 1:58 pm)
Re: [PATCH][resubmit] x86: enable preemption in delay, Ingo Molnar, (Wed Jun 18, 3:55 am)
Re: [PATCH][resubmit] x86: enable preemption in delay, Pavel Machek, (Sat Jun 28, 6:44 am)
Re: [PATCH][resubmit] x86: enable preemption in delay, Gregory Haskins, (Wed Jun 18, 8:08 am)
Re: [PATCH][resubmit] x86: enable preemption in delay, Peter Zijlstra, (Wed Jun 18, 8:16 am)
Re: [PATCH][resubmit] x86: enable preemption in delay, Gregory Haskins, (Wed Jun 18, 8:25 am)
Re: [PATCH][resubmit] x86: enable preemption in delay, Nick Piggin, (Wed Jun 18, 8:42 am)
Re: [PATCH][resubmit] x86: enable preemption in delay, Steven Rostedt, (Wed Jun 18, 12:16 pm)
Re: [PATCH][resubmit] x86: enable preemption in delay, Nick Piggin, (Wed Jun 18, 1:18 pm)
Re: [PATCH][resubmit] x86: enable preemption in delay, Gregory Haskins, (Wed Jun 18, 9:04 am)
Re: [PATCH][resubmit] x86: enable preemption in delay, Gregory Haskins, (Wed Jun 18, 8:13 am)
Re: [PATCH][resubmit] x86: enable preemption in delay, Andi Kleen, (Sun Jun 1, 12:25 pm)
Re: [PATCH -v4] x86: enable preemption in delay, Marin Mitov, (Mon May 26, 1:14 am)
Re:[PATCH -v4] x86: enable preemption in delay, Steven Rostedt, (Sun May 25, 3:30 pm)
Re: [PATCH -v4] x86: enable preemption in delay, Marin Mitov, (Sun May 25, 3:58 pm)