The user_regset_view table for the 32-bit regsets on the 64-bit build had
the wrong sizes for the FP regsets. This bug had no user-visible effect
(just on kernel modules using the user_regset interfaces and the like).
But the fix is trivial and risk-free.
Signed-off-by: Roland McGrath <roland@redhat.com>
---
arch/x86/kernel/ptrace.c | 7 +++++--
1 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/arch/x86/kernel/ptrace.c b/arch/x86/kernel/ptrace.c
index fb03ef3..a7835f2 100644
--- a/arch/x86/kernel/ptrace.c
+++ b/arch/x86/kernel/ptrace.c
@@ -1303,6 +1303,9 @@ static const struct user_regset_view user_x86_64_view = {
#define genregs32_get genregs_get
#define genregs32_set genregs_set
+#define user_i387_ia32_struct user_i387_struct
+#define user32_fxsr_struct user_fxsr_struct
+
#endif /* CONFIG_X86_64 */
#if defined CONFIG_X86_32 || defined CONFIG_IA32_EMULATION
@@ -1315,13 +1318,13 @@ static const struct user_regset x86_32_regsets[] = {
},
[REGSET_FP] = {
.core_note_type = NT_PRFPREG,
- .n = sizeof(struct user_i387_struct) / sizeof(u32),
+ .n = sizeof(struct user_i387_ia32_struct) / sizeof(u32),
.size = sizeof(u32), .align = sizeof(u32),
.active = fpregs_active, .get = fpregs_get, .set = fpregs_set
},
[REGSET_XFP] = {
.core_note_type = NT_PRXFPREG,
- .n = sizeof(struct user_i387_struct) / sizeof(u32),
+ .n = sizeof(struct user32_fxsr_struct) / sizeof(u32),
.size = sizeof(u32), .align = sizeof(u32),
.active = xfpregs_active, .get = xfpregs_get, .set = xfpregs_set
},
--
| David Newall | Re: Slow DOWN, please!!! |
| Greg Kroah-Hartman | [PATCH 005/196] Chinese: add translation of SubmittingDrivers |
| Fred . | Please add ZFS support (from GPL sources) |
| Andi Kleen | Please pull ACPI updates |
git: | |
| Peter Stahlir | Git as a filesystem |
| linux | [DRAFT] Branching and merging with git |
| Jakub Narebski | [PATCH 2/n] gitweb: Use '&iquot;' instead of '?' in esc_path |
| Junio C Hamano | Re: irc usage.. |
| Theo de Raadt | That whole "Linux stealing our code" thing |
| Koh Choon Lin | OBSD on MacBook |
| Floor Terra | Re: bcw(4) is gone |
| William Boshuck | Re: Real men don't attack straw men |
| Jim Winstead Jr. | Re: Root Disk/Book Disk Compatibility |
| Desmond A. Kirkpatrick | ATI GUP bug with Linux 'tickler' |
| David C. Niemi | Re: rsh: "rcmd: socket: Permission denied" |
| Theodore Ts'o | Re: help again and again |
