login
Header Space

 
 

[PATCH] RTC/watchdog: M41T80: Fix a potential use of unitialized data

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Alessandro Zummo <a.zummo@...>, Alexander Bigga <ab@...>, Andrew Morton <akpm@...>
Cc: Wim Van Sebroeck <wim@...>, <rtc-linux@...>, <linux-kernel@...>
Date: Friday, May 9, 2008 - 6:12 pm

Watchdog handlers within the driver make use of "save_client" -- make
sure it has been initalized before the handlers are registered.

Signed-off-by: Maciej W. Rozycki <macro@linux-mips.org>
---
 It should be obvious.  Please apply.

  Maciej

patch-2.6.26-rc1-20080505-m41t80-save_client-14
diff -up --recursive --new-file linux-2.6.26-rc1-20080505.macro/drivers/rtc/rtc-m41t80.c linux-2.6.26-rc1-20080505/drivers/rtc/rtc-m41t80.c
--- linux-2.6.26-rc1-20080505.macro/drivers/rtc/rtc-m41t80.c	2008-05-05 02:55:40.000000000 +0000
+++ linux-2.6.26-rc1-20080505/drivers/rtc/rtc-m41t80.c	2008-05-09 22:00:13.000000000 +0000
@@ -803,6 +803,7 @@ static int m41t80_probe(struct i2c_clien
 
 #ifdef CONFIG_RTC_DRV_M41T80_WDT
 	if (clientdata->features & M41T80_FEATURE_HT) {
+		save_client = client;
 		rc = misc_register(&wdt_dev);
 		if (rc)
 			goto exit;
@@ -811,7 +812,6 @@ static int m41t80_probe(struct i2c_clien
 			misc_deregister(&wdt_dev);
 			goto exit;
 		}
-		save_client = client;
 	}
 #endif
 	return 0;
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH] RTC/watchdog: M41T80: Fix a potential use of unitial..., Maciej W. Rozycki, (Fri May 9, 6:12 pm)
speck-geostationary