login
Header Space

 
 

Re: [RFC][PATCH 2/4] RTC: SWARM I2C board initialization

Score:
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Maciej W. Rozycki <macro@...>
Cc: Ralf Baechle <ralf@...>, Alessandro Zummo <a.zummo@...>, Thomas Gleixner <tglx@...>, Andrew Morton <akpm@...>, <rtc-linux@...>, <i2c@...>, <linux-mips@...>, <linux-kernel@...>, David Brownell <david-b@...>
Date: Friday, May 9, 2008 - 4:38 pm

Hi Maciej,

On Fri, 9 May 2008 21:27:04 +0100 (BST), Maciej W. Rozycki wrote:

I agree, i2c-sibyte is very old code, and unmaintained, coding style is
horrible. That's one more reason to not include random style cleanups
in a patch doing functional changes, the improvement will hardly be
visible. If you care about cleaning up the code of this driver - and I
would appreciate that - please make a separate patch.


And I thank you for that.

-- 
Jean Delvare
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[RFC][PATCH 2/4] RTC: SWARM I2C board initialization, Maciej W. Rozycki, (Tue May 6, 8:40 pm)
Re: [RFC][PATCH 2/4] RTC: SWARM I2C board initialization, Geert Uytterhoeven, (Wed May 7, 3:37 am)
Re: [RFC][PATCH 2/4] RTC: SWARM I2C board initialization, Maciej W. Rozycki, (Wed May 7, 5:25 pm)
Re: [RFC][PATCH 2/4] RTC: SWARM I2C board initialization, Maciej W. Rozycki, (Fri May 9, 3:36 pm)
Re: [RFC][PATCH 2/4] RTC: SWARM I2C board initialization, Maciej W. Rozycki, (Wed May 7, 5:13 pm)
Re: [RFC][PATCH 2/4] RTC: SWARM I2C board initialization, Maciej W. Rozycki, (Thu May 8, 7:10 pm)
Re: [RFC][PATCH 2/4] RTC: SWARM I2C board initialization, Maciej W. Rozycki, (Fri May 9, 4:27 pm)
Re: [RFC][PATCH 2/4] RTC: SWARM I2C board initialization, Jean Delvare, (Fri May 9, 4:38 pm)
Re: [RFC][PATCH 2/4] RTC: SWARM I2C board initialization, Maciej W. Rozycki, (Fri May 9, 9:43 pm)
Re: [RFC][PATCH 2/4] RTC: SWARM I2C board initialization, Maciej W. Rozycki, (Thu May 8, 6:43 pm)
speck-geostationary