login
Login
/
Register
Search
Header Space
Forums
News
Jobs
Blogs
Features
Man Pages
Site
Home
»
Mailing list archives
»
linux-kernel
»
2008
»
May
»
9
Re: [patch] video: fix build bugs in drivers/media/video/stk-webcam.c
view
thread
Score:
Previous message: [
thread
] [
date
] [
author
]
Next message: [thread] [
date
] [author]
[view in full thread]
From:
Jaime Velasco Juan <jsagarribay@...>
To: Mauro Carvalho Chehab <mchehab@...>
Cc: Ingo Molnar <mingo@...>, <linux-kernel@...>
Subject:
Re: [patch] video: fix build bugs in drivers/media/video/stk-webcam.c
Date: Friday, May 9, 2008 - 1:10 pm
El mié. 07 de may. de 2008, a las 16:29:50 -0300, Mauro Carvalho Chehab escribió:
quoted text
> The V4L1 symbols are used to help us to track what drivers are still using the > depreciated V4L1 API, or otherwise provide support for V4L1 compatibility > layer. This is not the case of stkwebcam. > > So, instead of the proposed patch, I prefer just to disable the additional > non-V4L2 sysfs interface, if the flag is not enabled.
Yeah, that might be the best solution to this problem.
quoted text
> > There are some discussions at the ML to create a standard to allow configuring > V4L2 controls via sysfs, but this is not standard yet. The idea is to add some > support at videodev.h using the same handlers defined by video_ioctl2. > Unfortunately, people stopped discussing this, due to the lack of time and > people to work on this. > > I think this could be a nice addition to V4L2, and will help to avoid creating > non-standardized interfaces at sysfs. > > > For the record, this bug was found in march, but it seems > > I forgot to CC: the patch to Mauro, Sorry about that. > > > >
http://marc.info/?l=linux-video&m=120594964524615&w=2
> > I probably missed this. > > --- > > Instead of Ingo's approach, this seems to be cleaner: > > Fix compilation, when V4L1_COMPAT is disabled > > From: Mauro Carvalho Chehab <mchehab@infradead.org> > > This driver uses some sysfs helper functions that are available only for legacy > drivers. It also requires linux/mm.h. > > This patch fixes compiliation when not in compat mode. > > Thanks to Ingo Molnar for identifying this issue. > > Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>
Acked-by: Jaime Velasco Juan <jsagarribay@gmail.com> Regards
quoted text
> --- > > drivers/media/video/stk-webcam.c | 7 +++++++ > 1 files changed, 7 insertions(+), 0 deletions(-) > > > diff --git a/drivers/media/video/stk-webcam.c b/drivers/media/video/stk-webcam.c > index 9276ed9..b12c60c 100644 > --- a/drivers/media/video/stk-webcam.c > +++ b/drivers/media/video/stk-webcam.c > @@ -30,6 +30,7 @@ > #include <linux/kref.h> > > #include <linux/usb.h> > +#include <linux/mm.h> > #include <linux/vmalloc.h> > #include <linux/videodev2.h> > #include <media/v4l2-common.h> > @@ -245,6 +246,8 @@ static int stk_initialise(struct stk_camera *dev) > return -1; > } > > +#ifdef CONFIG_VIDEO_V4L1_COMPAT > + > /* sysfs functions */ > /*FIXME cleanup this */ > > @@ -350,6 +353,10 @@ static void stk_remove_sysfs_files(struct video_device *vdev) > video_device_remove_file(vdev, &dev_attr_vflip); > } > > +#else > +#define stk_create_sysfs_files(a) > +#define stk_remove_sysfs_files(a) > +#endif > > /* *********************************************** */ > /* > > > > > > Cheers, > Mauro
--
unsubscribe notice
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to
majordomo@vger.kernel.org
More majordomo info at
http://vger.kernel.org/majordomo-info.html
Please read the FAQ at
http://www.tux.org/lkml/
Previous message: [
thread
] [
date
] [
author
]
Next message: [thread] [
date
] [author]
Messages in current thread:
[patch] video: fix build bugs in drivers/media/video/stk-web...
, Ingo Molnar
, (Tue Apr 29, 9:18 am)
Re: [patch] video: fix build bugs in drivers/media/video/stk...
, Jaime Velasco
, (Wed Apr 30, 3:11 am)
Re: [patch] video: fix build bugs in drivers/media/video/stk...
, Mauro Carvalho Chehab
, (Wed May 7, 3:29 pm)
Re: [patch] video: fix build bugs in drivers/media/video/stk...
, Jaime Velasco Juan
, (Fri May 9, 1:10 pm)
Navigation
Create content
Mailing list archives
Recent posts
Mail archive search
Enter your search terms.
all mailing lists
alsa-devel
dragonflybsd-bugs
dragonflybsd-commit
dragonflybsd-docs
dragonflybsd-kernel
dragonflybsd-submit
dragonflybsd-user
freebsd-announce
freebsd-bugs
freebsd-chat
freebsd-cluster
freebsd-current
freebsd-drivers
freebsd-embeded
freebsd-fs
freebsd-hackers
freebsd-hardware
freebsd-mobile
freebsd-net
freebsd-performance
freebsd-pf
freebsd-security
freebsd-security-notifications
freebsd-threads
git
git-commits-head
linux-activists
linux-arm
linux-ath5k-devel
linux-btrfs
linux-c-programming
linux-driver-devel
linux-ext4
linux-fsdevel
linux-ia64
linux-input
linux-kernel
linux-kernel-janitors
linux-kernel-mentors
linux-kernel-newbies
linux-kvm
linux-net
linux-netdev
linux-newbie
linux-nfs
linux-raid
linux-scsi
linux-security-module
linux-sparse
linux-usb
linux-usb-devel
madwifi-devel
netbsd-announce
netbsd-tech-kern
openbsd-announce
openbsd-bugs
openbsd-ipv6
openbsd-misc
openbsd-security-announce
openbsd-smp
openbsd-source-changes
openbsd-tech
openfabrics-general
openmoko-community
openmoko-devel
openmoko-kernel
reiserfs-devel
tux3
ucarp
Optionally limit your search to a specific mailing list.
advanced
Popular discussions
linux-kernel
:
Nigel Cunningham
Re: [Suspend2-devel] Re: CFS and suspend2: hang in atomic copy
Bart Van Assche
Integration of SCST in the mainstream Linux kernel
Greg Kroah-Hartman
[PATCH 005/196] Chinese: add translation of SubmittingDrivers
Rafael J. Wysocki
[Bug #10821] rt25xx: lock dependency warning, association failure, and kmalloc cor...
git
:
Martin Langhoff
Re: Change set based shallow clone
Karl
[StGIT PATCH] Don't use patches/<branch>/current
Andrew Morton
Untracked working tree files
Jon Smirl
! [rejected] master -> master (non-fast forward)
openbsd-misc
:
Richard Stallman
Real men don't attack straw men
askthelist
Packets Per Second Limit?
GVG GVG
ssh_exchange_identification: Connection closed by remote host
Renaud Allard
Spamd default behaviour of accepting everything
linux-netdev
:
Simon Horman
Re: [PATCHv2 RFC 05/25] IPVS: Add internal versions of sockopt interface structs
Lennert Buytenhek
[PATCH 08/39] mv643xx_eth: nuke port status register bit defines
Jiri Bohac
PATCH: fix bridged 802.3ad bonding
Natalie Protasevich
[BUG] New Kernel Bugs
Latest forum posts
make bzImage
8 hours ago
Linux kernel
make bzImage
9 hours ago
Linux kernel
collectl: the one performance monitoring tool for all your needs
11 hours ago
Linux general
Replacing Windows XP bootloader with GRUB bootloader
14 hours ago
Linux general
Anybody know where I can find an embedded sw engineer with good experience in digital video products???
16 hours ago
Windows
Problem in Inserting a module
19 hours ago
Linux kernel
stop process from getting scheduled out
1 day ago
Linux kernel
register_security LSM
1 day ago
Linux kernel
Process activity notification
1 day ago
Linux kernel
How to make my PCIE ATA storage device running in Linux
1 day ago
Linux general
Show all forums...
Recent Tags
more tags
Colocation donated by:
Who's online
There are currently
5 users
and
876 guests
online.
Online users
Jeremy
strcmp
catfeeder
Mr_Z
kingneutron
Syndicate
speck-geostationary