Port control interface (was Re: [PATCH] ata: ahci: power off unused ports)

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Mark Lord <liml@...>, Kristen Carlson Accardi <kristen.c.accardi@...>
Cc: <linux-ide@...>, <linux-kernel@...>, linux-scsi <linux-scsi@...>
Date: Friday, May 9, 2008 - 11:28 am

Mark Lord wrote:


In the grand open source tradition of "pass the buck", I've long been 
hoping that someone would take a few days, sit down, and hammer out the 
policy side of this.

We -don't- want to do hotplug-active all the time -- the current default 
in all drivers that support device hotplug -- because it needlessly 
keeps parts active that are unused 99.9% of the time [when they are empty].

Admins need a generic way to control SATA ports and links from 
userspace.  Within that, admins need to be able to set a link's hotplug 
state among three choices:  hotplug-active [when supported], 
hotplug-poll, and hotplug-never.  And of course, hotplug-poll's interval 
should be tunable.

And of course this control interface needs to be usable on SAS/SATA 
cards that will be common in the future (broadsas, mvsas are early 
examples).


This is why I look askance at an AHCI BIOS flag.  That's merely a hint, 
and potentially unreliable one at that.  It could just be describing 
what the BIOS writer felt were the ports that _should_ be hotpluggable 
-- i.e. not even describing what is _possible_ but someone's definition 
of "reasonable."  The BIOS flag might even be filled with fuzz (AHCI's 
BIOS-written registers have occasionally been shipped into the field 
uninitialized).

A better solution involves taking the BIOS flag and using that to set a 
default policy that an admin can easily override using the 
above-mentioned control interface.

Because in some cases, that BIOS flag might do the wrong thing, and we 
need to give the admin an ability to undo the damage.

	Jeff



--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH] ata: ahci: power off unused ports, Kristen Carlson Accardi, (Thu May 8, 7:10 pm)
Re: [PATCH] ata: ahci: power off unused ports, Theodore Tso, (Mon May 26, 11:08 pm)
Re: [PATCH] ata: ahci: power off unused ports, Kristen Carlson Accardi, (Tue May 27, 5:32 pm)
Re: [PATCH] ata: ahci: power off unused ports, Theodore Tso, (Tue May 27, 6:59 pm)
Re: [PATCH] ata: ahci: power off unused ports, Kristen Carlson Accardi, (Tue May 27, 7:32 pm)
Re: [PATCH] ata: ahci: power off unused ports, Pavel Machek, (Sat May 31, 4:00 am)
Re: [PATCH] ata: ahci: power off unused ports, Jeff Garzik, (Sun Jun 1, 3:16 pm)
Re: [PATCH] ata: ahci: power off unused ports, Alan Cox, (Mon Jun 2, 3:04 am)
Re: [PATCH] ata: ahci: power off unused ports, Jeff Garzik, (Mon Jun 2, 3:43 am)
Re: [PATCH] ata: ahci: power off unused ports, Mark Lord, (Mon Jun 2, 9:03 am)
Re: [PATCH] ata: ahci: power off unused ports, Kristen Carlson Accardi, (Mon Jun 2, 12:57 pm)
Re: [PATCH] ata: ahci: power off unused ports, Jeff Garzik, (Mon Jun 2, 1:44 pm)
Re: [PATCH] ata: ahci: power off unused ports, Jeff Garzik, (Mon Jun 2, 12:07 pm)
Re: [PATCH] ata: ahci: power off unused ports, Kristen Carlson Accardi, (Mon Jun 2, 1:00 pm)
Re: [PATCH] ata: ahci: power off unused ports, Jeff Garzik, (Mon Jun 2, 1:45 pm)
Re: [PATCH] ata: ahci: power off unused ports, Kristen Carlson Accardi, (Mon Jun 2, 1:47 pm)
Re: [PATCH] ata: ahci: power off unused ports, Jeff Garzik, (Mon Jun 2, 2:15 pm)
Re: [PATCH] ata: ahci: power off unused ports, Kristen Carlson Accardi, (Mon Jun 2, 2:16 pm)
Re: [PATCH] ata: ahci: power off unused ports, Jeff Garzik, (Mon Jun 2, 2:38 pm)
Re: [PATCH] ata: ahci: power off unused ports, Kristen Carlson Accardi, (Tue Jun 3, 12:49 pm)
Re: [PATCH] ata: ahci: power off unused ports, Ric Wheeler, (Mon Jun 2, 2:30 pm)
Re: [PATCH] ata: ahci: power off unused ports, Jeff Garzik, (Mon Jun 2, 2:40 pm)
Re: [PATCH] ata: ahci: power off unused ports, Matthew Garrett, (Mon Jun 2, 4:00 pm)
Re: [PATCH] ata: ahci: power off unused ports, Ric Wheeler, (Mon Jun 2, 2:49 pm)
Re: [PATCH] ata: ahci: power off unused ports, Jeff Garzik, (Mon Jun 2, 2:52 pm)
Re: [PATCH] ata: ahci: power off unused ports, Greg Freemyer, (Mon Jun 2, 1:07 pm)
Re: [PATCH] ata: ahci: power off unused ports, Alan Cox, (Mon Jun 2, 4:22 am)
Re: [PATCH] ata: ahci: power off unused ports, Jeff Garzik, (Mon Jun 2, 5:48 am)
Re: [PATCH] ata: ahci: power off unused ports, Kristen Carlson Accardi, (Mon Jun 2, 12:55 pm)
Re: [PATCH] ata: ahci: power off unused ports, Alan Cox, (Mon Jun 2, 9:54 am)
Re: [PATCH] ata: ahci: power off unused ports, Mark Lord, (Fri May 9, 11:06 am)
Port control interface (was Re: [PATCH] ata: ahci: power off..., Jeff Garzik, (Fri May 9, 11:28 am)
Re: [PATCH] ata: ahci: power off unused ports, Matthew Garrett, (Thu May 8, 7:37 pm)
Re: [PATCH] ata: ahci: power off unused ports, Lennart Sorensen, (Fri May 9, 11:58 am)
Re: [PATCH] ata: ahci: power off unused ports, Matthew Garrett, (Fri May 9, 12:06 pm)
Re: [PATCH] ata: ahci: power off unused ports, Lennart Sorensen, (Fri May 9, 12:14 pm)
Re: [PATCH] ata: ahci: power off unused ports, Kristen Carlson Accardi, (Fri May 9, 1:14 pm)
Re: [PATCH] ata: ahci: power off unused ports, Kristen Carlson Accardi, (Thu May 8, 7:35 pm)
Re: [PATCH] ata: ahci: power off unused ports, Matthew Garrett, (Thu May 8, 8:14 pm)
Re: [PATCH] ata: ahci: power off unused ports, Kristen Carlson Accardi, (Thu May 8, 8:28 pm)