login
Header Space

 
 

Re: [git patches] libata updates - (improve post-reset device ready test) regression

Score:
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Takashi Iwai <tiwai@...>
Cc: Markus Trippelsdorf <markus@...>, Jeff Garzik <jeff@...>, Andrew Morton <akpm@...>, Linus Torvalds <torvalds@...>, <linux-ide@...>, LKML <linux-kernel@...>, <htejun@...>
Date: Wednesday, May 7, 2008 - 11:13 pm

07/05/08 12:35 PM, Takashi Iwai:

Same here as well, with sata_nv.

The patch comment states:

 > This patch implements ata_check_ready(), which takes TF status value
 > and determines whether the port is ready or not considering the above
 > and other conditions, and use it in @check_ready() functions.  This is
 > safe as both 0x77 and 0x7f aren't valid ready status value even though
 > they have BSY bit cleared.

.. but adding a print to the ata_check_ready function shows the status in my 
case is systematically 0x7f for all unconnected links.  This makes 
ata_*_check_ready return 0 where it previously returned 1, and triggers several 
hundred retries (over several minutes) before the boot proceeds.

Marc
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[git patches] libata updates, Jeff Garzik, (Tue May 6, 11:48 am)
Re: [git patches] libata updates - (improve post-reset devic..., Markus Trippelsdorf, (Wed May 7, 10:56 am)
Re: [PATCH] Re: [git patches] libata updates - (improve post..., Markus Trippelsdorf, (Thu May 8, 12:18 pm)
Re: [git patches] libata updates - (improve post-reset devic..., Marc Dionne, (Wed May 7, 11:13 pm)
Re: [git patches] libata updates, Linus Torvalds, (Tue May 6, 12:23 pm)
speck-geostationary