login
Header Space

 
 

[PATCH 1/5] Fix cpumask_scnprintf_len() misdesign

Score:
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: <akpm@...>
Cc: <linux-kernel@...>
Date: Wednesday, May 7, 2008 - 6:14 pm

cpumask_scnprintf_len() takes "len" as an argument which is surprising,
If one follows call chain down it isn't length but number of bits. But
there is natural number of bits when talking about CPU masks -- NR_CPUS.
So use that.

Remove 1:1 wrapper macro while I'm at it.

Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
---

 include/linux/cpumask.h |    6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

--- a/include/linux/cpumask.h
+++ b/include/linux/cpumask.h
@@ -289,11 +289,9 @@ static inline int __cpumask_scnprintf(char *buf, int len,
 	return bitmap_scnprintf(buf, len, srcp->bits, nbits);
 }
 
-#define cpumask_scnprintf_len(len) \
-			__cpumask_scnprintf_len((len))
-static inline int __cpumask_scnprintf_len(int len)
+static inline int cpumask_scnprintf_len(void)
 {
-	return bitmap_scnprintf_len(len);
+	return bitmap_scnprintf_len(NR_CPUS);
 }
 
 #define cpumask_parse_user(ubuf, ulen, dst) \

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH 1/5] Fix cpumask_scnprintf_len() misdesign, Alexey Dobriyan, (Wed May 7, 6:14 pm)
Re: [PATCH 1/5] Fix cpumask_scnprintf_len() misdesign, Bert Wesarg, (Thu May 8, 11:01 am)
Re: [PATCH 1/5] Fix cpumask_scnprintf_len() misdesign, Andrew Morton, (Wed May 7, 5:35 pm)
Re: [PATCH 1/5] Fix cpumask_scnprintf_len() misdesign, Paul Jackson, (Wed May 7, 7:06 pm)
speck-geostationary