login
Login / Register
Header Space

 
 

Home » Mailing list archives » linux-kernel » 2008 » May » 7

Re: [patch] sound/video: fix sound/i2c/other/tea575x-tuner.c build bug

Previous thread: profile_pc oops in 2.6.18 by Dave Grothe on Tuesday, April 29, 2008 - 4:39 pm. (1 message)

Next thread: [PATCH RFC] kbuild: drop section mismatch detection for __cpu* by Sam Ravnborg on Tuesday, April 29, 2008 - 4:47 pm. (1 message)
[view original message]
From: Ingo Molnar <mingo@...>
To: <linux-kernel@...>
Cc: Takashi Iwai <tiwai@...>, Mauro Carvalho Chehab <mchehab@...>
Subject: [patch] sound/video: fix sound/i2c/other/tea575x-tuner.c build bug
Date: Tuesday, April 29, 2008 - 4:46 pm

fix build failure triggered on latest -git by this config:

 http://redhat.com/~mingo/misc/config-Tue_Apr_29_22_33_36_CEST_2008.bad

sound/i2c/other/tea575x-tuner.c: In function 'snd_tea575x_ioctl':
sound/i2c/other/tea575x-tuner.c:95: error: 'VIDIOCGCAP' undeclared (first use in this function)
sound/i2c/other/tea575x-tuner.c:95: error: (Each undeclared identifier is reported only once
sound/i2c/other/tea575x-tuner.c:95: error: for each function it appears in.)
sound/i2c/other/tea575x-tuner.c:97: error: storage size of 'v' isn't known

the CONFIG_SND_FM801_TEA575X code still depends on VIDEO_V4L1_COMPAT 
APIs.

Signed-off-by: Ingo Molnar &lt;mingo@elte.hu&gt;
---
 sound/pci/Kconfig |    1 +
 1 file changed, 1 insertion(+)

Index: linux/sound/pci/Kconfig
===================================================================
--- linux.orig/sound/pci/Kconfig
+++ linux/sound/pci/Kconfig
@@ -529,6 +529,7 @@ config SND_FM801_TEA575X
 	depends on SND_FM801_TEA575X_BOOL
 	default SND_FM801
 	select VIDEO_V4L1
+	select VIDEO_V4L1_COMPAT
 	select VIDEO_DEV
 
 config SND_HDA_INTEL
--
[view original message]
From: Takashi Iwai <tiwai@...>
To: Ingo Molnar <mingo@...>
Cc: <linux-kernel@...>, Mauro Carvalho Chehab <mchehab@...>
Subject: Re: [patch] sound/video: fix sound/i2c/other/tea575x-tuner.c build bug
Date: Wednesday, April 30, 2008 - 6:41 am

At Tue, 29 Apr 2008 22:46:43 +0200,

I'm afraid that the select of VIDEO_V4L1 from fm801 makes the things
messy enough.  And more select, eh...  IMO, this should be rather
depend on VIDEO_V4L1.

But, there is a dependency chain problem among snd-fm801,
snd-fm801-tea575x and V4L layer.  I'll check it.


--
[view original message]
From: Mauro Carvalho Chehab <mchehab@...>
To: Takashi Iwai <tiwai@...>
Cc: Ingo Molnar <mingo@...>, <linux-kernel@...>
Subject: Re: [patch] sound/video: fix sound/i2c/other/tea575x-tuner.c build bug
Date: Wednesday, May 7, 2008 - 3:36 pm

On Wed, 30 Apr 2008 12:41:52 +0200
Takashi Iwai &lt;tiwai@suse.de&gt; wrote:

Takashi,


Hmm... VIDEO_V4L1 where renamed as VIDEO_ALLOW_V4L1. Probably, this is what's
broken for SND_FM801_TEA575X.

Cheers,
Mauro
--
[view original message]
From: Takashi Iwai <tiwai@...>
To: Mauro Carvalho Chehab <mchehab@...>
Cc: Ingo Molnar <mingo@...>, <linux-kernel@...>
Subject: Re: [patch] sound/video: fix sound/i2c/other/tea575x-tuner.c build bug
Date: Thursday, May 8, 2008 - 6:33 am

At Wed, 7 May 2008 16:36:28 -0300,

Yes, and it was already fixed on Linus git tree.

Partly yes.


thanks,

Takashi
--
Previous thread: profile_pc oops in 2.6.18 by Dave Grothe on Tuesday, April 29, 2008 - 4:39 pm. (1 message)

Next thread: [PATCH RFC] kbuild: drop section mismatch detection for __cpu* by Sam Ravnborg on Tuesday, April 29, 2008 - 4:47 pm. (1 message)

Mail archive search
Enter your search terms.
Optionally limit your search to a specific mailing list.
advanced
Recent Tags
more tags
Colocation donated by:
Who's online
There are currently 4 users and 1156 guests online.

Online users

Syndicate
Syndicate content
© 2007 KernelTrap.  |  Powered by Drupal.  |  Legal statement.
speck-geostationary