Re: [RESEND][PATCH 00/11] sysfs tagged directories

view
thread

Score:

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

To: Daniel Lezcano <dlezcano@...>

Cc: Greg KH <gregkh@...>, Benjamin Thery <benjamin.thery@...>, <linux-kernel@...>, Eric W. Biederman <ebiederm@...>, Tejun Heo <htejun@...>, Al Viro <viro@...>, Serge E. Hallyn <serue@...>, Pavel Emelyanov <xemul@...>, <netdev@...>

Subject: Re: [RESEND][PATCH 00/11] sysfs tagged directories

Date: Wednesday, May 7, 2008 - 9:47 am

On Wed, May 7, 2008 at 3:19 PM, Daniel Lezcano <dlezcano@fr.ibm.com> wrote:
quoted text> Greg KH wrote:
>
> > On Tue, May 06, 2008 at 07:30:30PM +0200, Benjamin Thery wrote:
> >
> > > This is still the same port of Eric Biederman's patchset to implement
> > > tagged directories in sysfs that was discussed a few days ago.
> > >
> > > This time it applies on top of 2.6.26-rc1, which includes a fix from
> Daniel Lezcano to fix net device renaming
> > > for sysfs (and of course all the network namespaces stuff that was
> committed in net-2.6.26).
> > >
> > > This patchset still contains the patch from Serge Hallyn that implements
> > > tagging for user namespaces.
> > >
> > > It also contains a patch from Daniel Lezcano which allows to have net
> devices with the same name in two different network namespaces.
> > >
> >
> > Does this all work properly with both CONFIG_SYSFS_DEPRECATED enabled
> > and disabled?
> >
> > Can you show some outputs of 'tree' in both cases on the /sys/class/net/
> > directory?
> >
> > thanks,
> >
> > greg k-h
> >
>
>  Here is the output from an ls -l of /sys/class/net. I tryed with different
> configurations and checked the renamed network devices are propagated to the
> sysfs.

Thanks Daniel.
You covered more cases than I was planning to send :)

Benjamin

quoted text>
>  1) CONFIG_SYSFS_DEPRECATED && CONFIG_SYS && CONFIG_NET_NS
>  =========================================================
>
>  Outside a namespace:
>  --------------------
>
>  qemu:~> ip l
>  1: lo: <LOOPBACK,UP,10000> mtu 16436 qdisc noqueue
>     link/loopback 00:00:00:00:00:00 brd 00:00:00:00:00:00
>  2: eth0: <BROADCAST,MULTICAST,UP,10000> mtu 1500 qdisc pfifo_fast qlen 1000
>     link/ether 52:54:00:12:34:56 brd ff:ff:ff:ff:ff:ff
>  3: dummy0: <BROADCAST,NOARP> mtu 1500 qdisc noop
>     link/ether 1e:43:9e:1f:1f:55 brd ff:ff:ff:ff:ff:ff
>  4: br0: <BROADCAST,MULTICAST,UP,10000> mtu 1500 qdisc noqueue
>     link/ether 52:54:00:12:34:56 brd ff:ff:ff:ff:ff:ff
>  16: veth1: <BROADCAST,MULTICAST,PROMISC> mtu 1500 qdisc pfifo_fast qlen
> 1000
>     link/ether 8e:94:e6:72:63:cf brd ff:ff:ff:ff:ff:ff
>
>  qemu:~/lxc> ll /sys/class/net/
>  total 0
>  drwxr-xr-x 5 root root 0 2008-05-07 15:24 br0
>  drwxr-xr-x 3 root root 0 2008-05-07 13:16 dummy0
>  drwxr-xr-x 4 root root 0 2008-05-07 15:24 eth0
>  drwxr-xr-x 3 root root 0 2008-05-07 13:16 lo
>  drwxr-xr-x 4 root root 0 2008-05-07 15:26 veth1
>
>
>  Inside the namespace:
>  ----------------------
>
>  qemu:~> ip l
>  14: lo: <LOOPBACK,UP,10000> mtu 16436 qdisc noqueue
>     link/loopback 00:00:00:00:00:00 brd 00:00:00:00:00:00
>  15: veth2: <BROADCAST,MULTICAST,UP,10000> mtu 1500 qdisc pfifo_fast qlen
> 1000
>     link/ether 46:85:e5:76:90:05 brd ff:ff:ff:ff:ff:ff
>
>  virtnode:~lxc # ll /sys/class/net/
>  total 0
>  drwxr-xr-x 3 root root 0 May  7 15:28 lo
>  drwxr-xr-x 3 root root 0 May  7 15:26 veth2
>
>  2) CONFIG_SYSFS && CONFIG_NET_NS
>  ================================
>
>
>  Outside the namespace:
>  ----------------------
>
>  qemu:~> ip l
>  1: lo: <LOOPBACK,UP,10000> mtu 16436 qdisc noqueue
>     link/loopback 00:00:00:00:00:00 brd 00:00:00:00:00:00
>  2: eth0: <BROADCAST,MULTICAST,UP,10000> mtu 1500 qdisc pfifo_fast qlen 1000
>     link/ether 52:54:00:12:34:56 brd ff:ff:ff:ff:ff:ff
>  3: dummy0: <BROADCAST,NOARP> mtu 1500 qdisc noop
>     link/ether 72:16:3d:88:11:70 brd ff:ff:ff:ff:ff:ff
>  4: br0: <BROADCAST,MULTICAST,UP,10000> mtu 1500 qdisc noqueue
>     link/ether 52:54:00:12:34:56 brd ff:ff:ff:ff:ff:ff
>  13: veth1: <BROADCAST,MULTICAST,PROMISC> mtu 1500 qdisc pfifo_fast qlen
> 1000
>     link/ether aa:6f:e8:dd:b8:ba brd ff:ff:ff:ff:ff:ff
>
>   * Content of /sys/class/net:
>
>  qemu:~/lxc> ll /sys/class/net/
>  total 0
>  lrwxrwxrwx 1 root root 0 2008-05-07 14:31 br0 ->
> ../../devices/virtual/net/br0
>  lrwxrwxrwx 1 root root 0 2008-05-07 14:28 dummy0 ->
> ../../devices/virtual/net/dummy0
>  lrwxrwxrwx 1 root root 0 2008-05-07 14:28 eth0 ->
> ../../devices/pci0000:00/0000:00:03.0/net/eth0
>  lrwxrwxrwx 1 root root 0 2008-05-07 14:28 lo ->
> ../../devices/virtual/net/lo
>  lrwxrwxrwx 1 root root 0 2008-05-07 14:35 veth1 ->
> ../../devices/virtual/net/veth1
>
>  Inside the namespace:
>  ----------------------
>
>  qemu:~> ip l
>  11: lo: <LOOPBACK,UP,10000> mtu 16436 qdisc noqueue
>     link/loopback 00:00:00:00:00:00 brd 00:00:00:00:00:00
>  12: veth2: <BROADCAST,MULTICAST,UP,10000> mtu 1500 qdisc pfifo_fast qlen
> 1000
>     link/ether ee:c5:a3:7c:58:bd brd ff:ff:ff:ff:ff:ff
>
>  virtnode:~/lxc # ll /sys/class/net/
>  total 0
>  lrwxrwxrwx 1 root root 0 May  7 14:40 lo -> ../../devices/virtual/net/lo
>  lrwxrwxrwx 1 root root 0 May  7 14:40 veth2 ->
> ../../devices/virtual/net/veth2
>
>
>  3) CONFIG_SYSFS
>  ===============
>
>  qemu:~> ip l
>  1: lo: <LOOPBACK,UP,10000> mtu 16436 qdisc noqueue
>     link/loopback 00:00:00:00:00:00 brd 00:00:00:00:00:00
>  2: eth0: <BROADCAST,MULTICAST,UP,10000> mtu 1500 qdisc pfifo_fast qlen 1000
>     link/ether 52:54:00:12:34:56 brd ff:ff:ff:ff:ff:ff
>  3: dummy0: <BROADCAST,NOARP> mtu 1500 qdisc noop
>     link/ether 6e:3a:5f:2f:fa:cb brd ff:ff:ff:ff:ff:ff
>  4: br0: <BROADCAST,MULTICAST,UP,10000> mtu 1500 qdisc noqueue
>     link/ether 52:54:00:12:34:56 brd ff:ff:ff:ff:ff:ff
>
>  qemu:~/lxc> ll /sys/class/net/
>  total 0
>  lrwxrwxrwx 1 root root 0 2008-05-07 15:01 br0 ->
> ../../devices/virtual/net/br0
>  lrwxrwxrwx 1 root root 0 2008-05-07 14:59 dummy0 ->
> ../../devices/virtual/net/dummy0
>  lrwxrwxrwx 1 root root 0 2008-05-07 14:59 eth0 ->
> ../../devices/pci0000:00/0000:00:03.0/net/eth0
>  lrwxrwxrwx 1 root root 0 2008-05-07 14:59 lo ->
> ../../devices/virtual/net/lo
>
>  4) CONFIG_SYSFS_DEPRECATED && CONFIG_SYSFS
>  ==========================================
>
>  qemu:~> ip l
>  1: lo: <LOOPBACK,UP,10000> mtu 16436 qdisc noqueue
>     link/loopback 00:00:00:00:00:00 brd 00:00:00:00:00:00
>  2: eth0: <BROADCAST,MULTICAST,UP,10000> mtu 1500 qdisc pfifo_fast qlen 1000
>     link/ether 52:54:00:12:34:56 brd ff:ff:ff:ff:ff:ff
>  3: dummy0: <BROADCAST,NOARP> mtu 1500 qdisc noop
>     link/ether 16:85:f0:a8:34:44 brd ff:ff:ff:ff:ff:ff
>  4: br0: <BROADCAST,MULTICAST,UP,10000> mtu 1500 qdisc noqueue
>     link/ether 52:54:00:12:34:56 brd ff:ff:ff:ff:ff:ff
>
>  qemu:~> ll /sys/class/net/
>  total 0
>  drwxr-xr-x 5 root root 0 2008-05-07 15:07 br0
>  drwxr-xr-x 3 root root 0 2008-05-07 15:06 dummy0
>  drwxr-xr-x 4 root root 0 2008-05-07 15:07 eth0
>  drwxr-xr-x 3 root root 0 2008-05-07 15:06 lo
>
>
>  --
>  To unsubscribe from this list: send the line "unsubscribe netdev" in
>  the body of a message to majordomo@vger.kernel.org
>  More majordomo info at  http://vger.kernel.org/majordomo-info.html
>
--
unsubscribe noticeTo unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:

[RESEND][PATCH 00/11] sysfs tagged directories , Benjamin Thery, (Tue May 6, 1:30 pm)

Re: [RESEND][PATCH 00/11] sysfs tagged directories, Greg KH, (Tue May 6, 1:53 pm)

Re: [RESEND][PATCH 00/11] sysfs tagged directories, Daniel Lezcano, (Wed May 7, 9:19 am)

Re: [RESEND][PATCH 00/11] sysfs tagged directories, Benjamin Thery, (Wed May 14, 11:07 am)

Re: [RESEND][PATCH 00/11] sysfs tagged directories, Benjamin Thery, (Wed May 7, 9:47 am)

Re: [RESEND][PATCH 00/11] sysfs tagged directories, Benjamin Thery, (Tue May 6, 2:41 pm)

Navigation

Mail archive search

Popular discussions


linux-kernel:
Artem Bityutskiy	[PATCH 00/22 take 3] UBI: Unsorted Block Images
Greg Kroah-Hartman	[PATCH 022/196] adb: Convert from class_device to device
Parag Warudkar	BUG: soft lockup - CPU#1 stuck for 15s! [swapper:0]
Ingo Molnar	Re: pthread_create() slow for many threads; also time to revisit 64b context switc...
git:
Bill Lear	Meaning of "fatal: protocol error: bad line length character"?
Ludovic	`git-send-email' doesn't specify `Content-Type'
Miles Bader	multiple-commit cherry-pick?
JD Guzman	C# Git Implementation
openbsd-misc:
Martin Schröder	Re: Real men don't attack straw men
Jacob Meuser	Re: esd + mpd
Daniel Ouellet	identifying sparse files and get ride of them trick available?
Todd Pytel	IDE or SCSI virtual disks for VMWare image?
linux-netdev:
David Miller	Re: kernel oops when system under network stress
Denys Fedoryshchenko	thousands of classes, e1000 TX unit hang
Eric Dumazet	[PATCH 6/6] fs: Introduce kern_mount_special() to mount special vfs
Леонид Юрьев	[r8169] patch for RTL8102 (5 new MAC/PHY)

Latest forum posts


Serial Driver Implementation Help	15 minutes ago	Linux kernel
aacraid bad	50 minutes ago	Linux general
Does ICH8 support AHCI?	10 hours ago	Linux kernel
Tools: GCC 3.4.6, Final GCC 3 Release	20 hours ago	Applications and Utilities
GNU/Hurd is so awful	1 day ago	GNU/Hurd
read /dev/mem not working in 2.6	3 days ago	Linux general
Issues with NETLINK sockets	4 days ago	Linux kernel
Anyone experiancing compiling issues with 2.6.26.6 patching with rt patch 2.6.26.6-rt11?	4 days ago	Linux kernel
Change network interface from eth0 to ppp0	4 days ago	Linux general
kernel module to intercept socket creation	5 days ago	Linux kernel

Show all forums...

Recent Tags

more tags

Colocation donated by:

Online users

Syndicate