On Wed, 2008-05-07 at 01:40 +0100, Maciej W. Rozycki wrote:Ooh, shiny -- you saved me the trouble of doing this (and hopefully also the trouble of looking through it to check whether all the callers of read_persistent_clock() can sleep, etc.?) One thing I was going to do in rtc_update_persistent_clock() was make it use mutex_trylock() for grabbing rtc->lock. We go to great lengths to make sure we're updating the clock at the correct time -- we don't want to be doing things which delay the update. So we should probably just use mutex_trylock() and abort the update (this time) if it fails. I was also thinking of holding the RTC_HCTOSYS device open all the time, too. If it's a problem that you then couldn't unload the module, perhaps a sysfs interface to set/change/clear which device is used for this? When we discussed it last week, Alessandro was concerned that the 'update at precisely 500ms past the second' rule was not universal to all RTC devices, although I'm not entirely sure. It might be worth moving that logic into a 'default' NTP-sync routine provided by the RTC class, so that if any strange devices exist which require different treatment, they can override that. I wouldn't worry too much about leaving the old update_persistent_clock() and read_persistent_clock() -- I hope we can plan to remove those entirely in favour of the RTC class methods. -- dwmw2 --
| Eric Paris | TALPA - a threat model? well sorta. |
| Greg Kroah-Hartman | [PATCH 004/196] Chinese: add translation of SubmittingPatches |
| Linus Torvalds | Linux 2.6.27-rc8 |
| Rafael J. Wysocki | [Bug #10741] bug in `tty: BKL pushdown'? |
git: | |
| David Brown | Re: Something is broken in repack |
| H. Peter Anvin | Re: First cut at git port to Cygwin |
| Kevin Leung | Edit log message after commit |
| Johannes Schindelin | Re: Official Git Homepage change? Re: git-scm.com |
| Richard Stallman | Real men don't attack straw men |
| GVG GVG | ssh_exchange_identification: Connection closed by remote host |
| Daniel Ouellet | identifying sparse files and get ride of them trick available? |
| Michael | Re: running mail server at home |
| Gerrit Renker | [PATCH 13/37] dccp: Deprecate Ack Ratio sysctl |
| David Miller | Re: [PATCH] pkt_sched: Destroy gen estimators under rtnl_lock(). |
| Jussi Kivilinna | [PATCH 02/14] [cdc_ether] Hardwire CDC descriptors when missing |
| Denis V. Lunev | [PATCH 12/17 net-2.6.26] [NETNS]: Process /proc/net/rt_cache inside a namespace. |
