This patch is to be applied on top of the series which adds the flag parameters. It removes the size parameter from the new epoll_create syscall and renames the syscall itself. The updated test program follows. ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ #include <fcntl.h> #include <stdio.h> #include <time.h> #include <unistd.h> #include <sys/syscall.h> #ifndef __NR_epoll_create2 # ifdef __x86_64__ # define __NR_epoll_create2 291 ...

It breaks things how? Because on x86, the cut-off is gcc4 vs pre-4. See arch/x86/Makefile: KBUILD_CFLAGS += $(shell if [ $(call cc-version) -lt 0400 ] ; then \ echo $(call cc-option,-fno-unit-at-a-time); fi ;) and it's a bit distressing that these compiler flags are set two different ways (in fact, I was already bothered by the fact that UML sets it totally independently of x86 in the first place). So what is the UML failure behaviour with gcc-4.1.2? Linu...

The input argument to rtc_time_to_tm() is unsigned as well as are members of the output structure. However signed arithmetic is used within for calculations leading to incorrect results for input values outside the signed positive range. If this happens the time of day returned is out of range. Found the problem when fiddling with the RTC and the driver where year was set to an unexpectedly large value like 2070, e.g.: rtc0: setting system clock to 2070-01-01 1193046:71582832:26 UTC (31557609...

Hi, Although the freezer is generally considered as a bad thing, it still is being used for suspend and hibernation and will be used for these purposes in the near future. For this reason, it seems reasonable to try to reduce some known problems with it. The following two patches attempt to do that. First, it is the known weakness of the freezer that it tries to distinguish user space processes from kernel threads in a slightly artificial way. The first patch is intended to change that. Sec...

[Empty message]

I was told by SanDisk when CF first came out to ignore what the "lynix guys" (sic) were saying when I was excoriated on this list for saying that everything one needs to do is already incorporated into the Compact Flash and it needs only to be treated as a disk, nothing else! Compact Flash is not just some flash RAM with an IDE interface plug. It contains both static RAM and flash RAM. It goes by pages and a stale page is flushed to flash when a new page is being accessed, or when other (propr...

This patch is by far the most complex in the series. It adds a new syscall paccept. This syscall differs from accept in that it adds (at the userlevel) two additional parameters: - a signal mask - a flags value The flags parameter can be used to set flag like SOCK_CLOEXEC. This is imlpemented here as well. Some people argued that this is a property which should be inherited from the file desriptor for the server but this is against POSIX. Additionally, we really want the signal mask parame...

This patch introduces the new syscall pipe2 which is like pipe but it also takes an additional parameter which takes a flag value. This patch implements the handling of O_CLOEXEC for the flag. I did not add support for the new syscall for the architectures which have a special sys_pipe implementation. I think the maintainers of those archs have the chance to go with the unified implementation but that's up to them. The implementation introduces do_pipe_flags. I did that instead of changing all ...

This patch introduces support for the SOCK_NONBLOCK flag in socket, socketpair, and paccept. To do this the internal function sock_attach_fd gets an additional parameter which it uses to set the appropriate flag for the file descriptor. Given that in modern, scalable programs almost all socket connections are non-blocking and the minimal additional cost for the new functionality I see no reason not to add this code. The following test must be adjusted for architectures other than x86 and x86-6...

This patch adds the new dup3 syscall. It extends the old dup2 syscall by one parameter which is meant to hold a flag value. Support for the O_CLOEXEC flag is added in this patch. The following test must be adjusted for architectures other than x86 and x86-64 and in case the syscall numbers changed. ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ #include <fcntl.h> #include <stdio.h> #include <time.h> #include <unistd.h> #include <sys/syscall...

This patch introduces the new syscall inotify_init1 (note: the 1 stands for the one parameter the syscall takes, as opposed to no parameter before). The values excepted for this parameter are function-specific and defined in the inotify.h header. Here the values must match the O_* flags, though. In this patch CLOEXEC support is introduced. The following test must be adjusted for architectures other than x86 and x86-64 and in case the syscall numbers changed. ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~...

This is perfectly fine for me. Since the flags space for these new syscalls is almost empty, it makes perfect sense to just map them to the original O_* flags. Acked-by: Davide Libenzi <davidel@xmailserver.org> (for the whole serie) - Davide --

This patch adds support for flag values which are ORed to the type passwd to socket and socketpair. The additional code is minimal. The flag values in this implementation can and must match the O_* flags. This avoids overhead in the conversion. The internal functions sock_alloc_fd and sock_map_fd get a new parameters and all callers are changed. ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ #include <fcntl.h> #include <stdio.h> #include <unistd.h> ...

The timerfd_create syscall already has a flags parameter. It just is unused so far. This patch changes this by introducing the TFD_CLOEXEC flag to set the close-on-exec flag for the returned file descriptor. A new name TFD_CLOEXEC is introduced which in this implementation must have the same value as O_CLOEXEC. The following test must be adjusted for architectures other than x86 and x86-64 and in case the syscall numbers changed. ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~...

This is an update for the previous series which should address the comments Andrew had. The controversial function Davide wrote is gone. There is no flag conversion anymore. We still introduce new names for the constants but the values are the same as the O_* constants. This leads to some strange-looking code where we in one moment check for, say, SOCK_CLOEXEC, and in the next for O_CLOEXEC. But I added in a separate, new patch code which checks for the consistency of the constants. I modifie...

This patch adds support for the SFD_NONBLOCK flag to signalfd4. The additional changes needed are minimal. The following test must be adjusted for architectures other than x86 and x86-64 and in case the syscall numbers changed. ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ #include <fcntl.h> #include <signal.h> #include <stdio.h> #include <unistd.h> #include <sys/syscall.h> #ifndef __NR_signalfd4 # ifdef __x86_64__ # define __NR_sig...

From: Christoph Hellwig <hch@lst.de> Signed-off-by: Christoph Hellwig <hch@lst.de> Acked-by: Evgeniy Dushistov <dushistov@mail.ru> diff --git a/fs/ufs/ufs.h b/fs/ufs/ufs.h index 244a1aa..11c0351 100644 --- a/fs/ufs/ufs.h +++ b/fs/ufs/ufs.h @@ -107,7 +107,6 @@ extern struct inode * ufs_new_inode (struct inode *, int); /* inode.c */ extern struct inode *ufs_iget(struct super_block *, unsigned long); -extern void ufs_put_inode (struct inode *); extern int ufs_write_inode ...

Did you use "debugpat" kernel boot option after applying Ingo's patch? With Ingo's patch, that option is needed to print more info (Not needed with one line change I sent you yday). Also, 'dmesg -s 256000' will not truncate the msg at 32K and will give bigger dmesg output. Thanks, Venki --

Yes. This has some debug information in there. Did you see xf86MapVidMem error (I mean did you try to start X) before you captured this dmesg? Thanks, Venki --

[Empty message]

The first patch simply puts both 32 and 64 bit headers into one header file. The #ifdef sequence at the top is shared. Signed-off-by: Christoph Lameter <clameter@sgi.com> --- include/asm-x86/e820.h | 103 +++++++++++++++++++++++++++++++++++++++++++++- include/asm-x86/e820_32.h | 50 ---------------------- include/asm-x86/e820_64.h | 56 ------------------------- 3 files changed, 101 insertions(+), 108 deletions(-) Index: linux-2.6/include/asm-x86/e820.h ========================...

The comments are basically the same. Take the 64 bit version as the common comments. Signed-off-by: Christoph Lameter <clameter@sgi.com> --- include/asm-x86/e820.h | 26 +++++++------------------- 1 file changed, 7 insertions(+), 19 deletions(-) Index: linux-2.6/include/asm-x86/e820.h =================================================================== --- linux-2.6.orig/include/asm-x86/e820.h 2008-05-06 11:46:45.000000000 -0700 +++ linux-2.6/include/asm-x86/e820.h 2008-05-06 11:48:09...

V1->V2: - Harmonize calling conventions betwen 32 and 64 bit. Use u64 if 32 bit uses unsigned long long or u64. The following patchset merges the 32 and 64 bit of e820 header files into one. First just move the stuff into a single file and then gradually extract common code. Patch against Linus' git tree of today. -- --

Remove #ifdef CONFIG_OF_I2C as this breaks module compilation. Drivers using this header should depend on OF_I2C anyways, so there's no need to make this conditional Signed-off-by: Jochen Friedrich <jochen@scram.de> --- include/linux/of_i2c.h | 4 ---- 1 files changed, 0 insertions(+), 4 deletions(-) diff --git a/include/linux/of_i2c.h b/include/linux/of_i2c.h index 2e5a967..bd2a870 100644 --- a/include/linux/of_i2c.h +++ b/include/linux/of_i2c.h @@ -14,11 +14,7 @@ #include &lt...

[ 0.000000] Initializing cgroup subsys cpuset [ 0.000000] Linux version 2.6.26-rc1-next-20080506 (thomas@dhcppc1) (gcc version 4.1.2 20070925 (Red Hat 4.1.2-33)) #23 SMP Tue May 6 19:04:11 CEST 2008 [ 0.000000] BIOS-provided physical RAM map: [ 0.000000] BIOS-e820: 0000000000000000 - 000000000009fc00 (usable) [ 0.000000] BIOS-e820: 000000000009fc00 - 00000000000a0000 (reserved) [ 0.000000] BIOS-e820: 00000000000e0000 - 0000000000100000 (reserved) [ 0.000000] BIOS-e820: 0000000...