Mauro Carvalho Chehab wrote:^^^^ Yes... Except that it is very dangerous to /move/ dependencies, as you are apparently doing in that patch. When you use "select" somewhere, you should generally /copy/ dependencies. Although something like config VIRTUAL_META_OPTION depends on REAL_DEPENDENCY config THE_REAL_THING depends on VIRTUAL_META_OPTION does work if THE_REAL_THING actually depends on REAL_DEPENDENCY, it is safer if this dependency stays there, i.e. config THE_REAL_THING depends on REAL_DEPENDECY or config THE_REAL_THING depends on REAL_DEPENDENCY && VIRTUAL_META_OPTION or whatever, or equivalent constructs involving "if"..."endif". (I presume that for example MEDIA_TUNER_TDA827X does indeed have a build dependency on DVB_CORE && I2C.) Or in other words: Since MEDIA_TUNER selects a bunch of options which itself have build dependencies, you /must/ duplicate all of their dependencies to MEDIA_TUNER. Well, actually you don't use plain "select", you use "select ... if !MEDIA_TUNER_CUSTOMIZE". So if you can ensure by other means that those 2nd level dependencies are guaranteed to be fulfilled whenever MEDIA_TUNER_CUSTOMIZE=n, then you don't need to duplicate the 2nd level dependencies into MEDIA_TUNER. That's the same what I meant in my comment on VIDEO_HELPER_CHIPS_AUTO: Those options which "select" video decoders generally /must/ contain duplicates of the dependency statements of the decoders which they select. Except, since you don't use plain "select" there but actually "select ... if VIDEO_HELPER_CHIPS_AUTO", you can alternatively put the duplicates of the dependency statements to VIDEO_HELPER_CHIPS_AUTO. -- Stefan Richter -=====-==--- -=-= --=== http://arcgraph.de/sr/ --
| Fred . | Please add ZFS support (from GPL sources) |
| Kristen Carlson Accardi | Re: PCIe Hotplug: NFG unless I boot with card already inserted. |
| Chuck Ebbert | Why do so many machines need "noapic"? |
| Linus Torvalds | Re: [GIT]: Networking |
git: | |
| Petr Baudis | Re: Cogito: cg-clone doesn't like packed tag objects |
| Andreas Ericsson | Re: [PATCH] git-merge: add option --no-ff |
| Junio C Hamano | GIT 0.99.6 |
| Wayne Scott | git-diff-tree rename detection bug |
| Unix Fan | Re: Vulnerability Note VU#800113 - Multiple DNS implementations vulnerable to cach... |
| Edd Barrett | Iwi, wireless bad behavior |
| jose thomas | Resume - Mumps Developer |
| Girish Venkatachalam | Ethernet jumbo frames? |
| Gregory McGarry | Re: Lock benchmarks |
| Perry E. Metzger | Re: HEADS UP: kqueue support merged |
| Frederick Bruckman | Re: POSIX timer_settime() dosn't set timer in some cases (lost accuracy) |
| jonathan | Re: Interrupt, interrupt threads, continuations, and kernel lwps |
