Mauro Carvalho Chehab wrote:^^^^ Yes... Except that it is very dangerous to /move/ dependencies, as you are apparently doing in that patch. When you use "select" somewhere, you should generally /copy/ dependencies. Although something like config VIRTUAL_META_OPTION depends on REAL_DEPENDENCY config THE_REAL_THING depends on VIRTUAL_META_OPTION does work if THE_REAL_THING actually depends on REAL_DEPENDENCY, it is safer if this dependency stays there, i.e. config THE_REAL_THING depends on REAL_DEPENDECY or config THE_REAL_THING depends on REAL_DEPENDENCY && VIRTUAL_META_OPTION or whatever, or equivalent constructs involving "if"..."endif". (I presume that for example MEDIA_TUNER_TDA827X does indeed have a build dependency on DVB_CORE && I2C.) Or in other words: Since MEDIA_TUNER selects a bunch of options which itself have build dependencies, you /must/ duplicate all of their dependencies to MEDIA_TUNER. Well, actually you don't use plain "select", you use "select ... if !MEDIA_TUNER_CUSTOMIZE". So if you can ensure by other means that those 2nd level dependencies are guaranteed to be fulfilled whenever MEDIA_TUNER_CUSTOMIZE=n, then you don't need to duplicate the 2nd level dependencies into MEDIA_TUNER. That's the same what I meant in my comment on VIDEO_HELPER_CHIPS_AUTO: Those options which "select" video decoders generally /must/ contain duplicates of the dependency statements of the decoders which they select. Except, since you don't use plain "select" there but actually "select ... if VIDEO_HELPER_CHIPS_AUTO", you can alternatively put the duplicates of the dependency statements to VIDEO_HELPER_CHIPS_AUTO. -- Stefan Richter -=====-==--- -=-= --=== http://arcgraph.de/sr/ --
| Stephen Smalley | Re: [AppArmor 39/45] AppArmor: Profile loading and manipulation, pathname matching |
| Tarkan Erimer | Re: Dual-Licensing Linux Kernel with GPL V2 and GPL V3 |
| Jan Engelhardt | intel iommu (Re: -mm merge plans for 2.6.23) |
| Greg Kroah-Hartman | [PATCH 005/196] Chinese: add translation of SubmittingDrivers |
git: | |
| David Fenyes | sigsetmask()? (LINUX) |
| Stephen Tweedie | Unmounting root (no kidding!) [was: Some Linux problems---solved] |
| Les Andrzejewski | X386/WD90C31/SUMSUNG SYNC MASTER 4 |
| Doug Evans | Re: Stabilizing Linux |
| Gerrit Renker | [PATCH 27/37] dccp: Integration of dynamic feature activation - part 2 (server side) |
| Linus Torvalds | Re: [GIT]: Networking |
| Jarek Poplawski | [PATCH] pkt_sched: Destroy gen estimators under rtnl_lock(). |
| Herbert Xu | Re: [PATCH] myr10ge: again fix lro_gen_skb() alignment |
