login
Header Space

 
 

[PATCH] fix UML on x86-64

Score:
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: <linux-kernel@...>, <user-mode-linux-devel@...>
Cc: <akpm@...>, <mingo@...>, <tglx@...>, <torvalds@...>
Date: Tuesday, May 6, 2008 - 7:04 pm

This patch breaks UML for me on x86-64 running Fedora 8 (gcc 4.1.2):

commit 22eecde2f9034764a3fd095eecfa3adfb8ec9a98
Author: Ingo Molnar <mingo@elte.hu>
Date:   Thu May 1 12:06:54 2008 +0200

    uml: fix gcc problem
    
    this is what caused gcc 4.3 to throw an internal error when
    OPTIMIZE_INLINING was enabled ...
    
    Signed-off-by: Ingo Molnar <mingo@elte.hu>
    Signed-off-by: Thomas Gleixner <tglx@linutronix.de>


If you want to use the option for gcc 4.3 then do it, but only for those
versions.  I haven't tested whether gcc 4.2 and 4.3 works, I just know
that gcc 4.1.2 needs the option for some reason.


Signed-off-by: Ulrich Drepper <drepper@redhat.com>

diff --git a/arch/um/Makefile b/arch/um/Makefile
index 01b97c1..3f52a8c 100644
--- a/arch/um/Makefile
+++ b/arch/um/Makefile
@@ -77,9 +77,9 @@ include $(srctree)/$(ARCH_DIR)/Makefile-os-$(OS)
 KERNEL_DEFINES = $(strip -Derrno=kernel_errno -Dsigprocmask=kernel_sigprocmask \
 			 -Dmktime=kernel_mktime $(ARCH_KERNEL_DEFINES))
 KBUILD_CFLAGS += $(KERNEL_DEFINES)
-# Disable unit-at-a-time mode on pre-gcc-4.0 compilers, it makes gcc use
+# Disable unit-at-a-time mode on pre-gcc-4.3 compilers, it makes gcc use
 # a lot more stack due to the lack of sharing of stacklots:
-KBUILD_CFLAGS += $(shell if [ $(call cc-version) -lt 0400 ] ; then \
+KBUILD_CFLAGS += $(shell if [ $(call cc-version) -lt 0430 ] ; then \
 			echo $(call cc-option,-fno-unit-at-a-time); fi ;)
 
 PHONY += linux
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH] fix UML on x86-64, Ulrich Drepper, (Tue May 6, 7:04 pm)
Re: [uml-devel] [PATCH] fix UML on x86-64, Jeff Dike, (Wed May 7, 12:00 am)
Re: [PATCH] fix UML on x86-64, Linus Torvalds, (Tue May 6, 7:27 pm)
Re: [PATCH] fix UML on x86-64, Ulrich Drepper, (Tue May 6, 7:38 pm)
Re: [uml-devel] [PATCH] fix UML on x86-64, Jeff Dike, (Tue May 6, 11:26 pm)
Re: [PATCH] fix UML on x86-64, Jeff Dike, (Tue May 6, 9:31 pm)
Re: [PATCH] fix UML on x86-64, Linus Torvalds, (Tue May 6, 8:06 pm)
Re: [PATCH] fix UML on x86-64, Jeff Dike, (Tue May 6, 9:48 pm)
Re: [PATCH] fix UML on x86-64, Linus Torvalds, (Tue May 6, 8:15 pm)
speck-geostationary