login
Login
/
Register
Search
Search this site:
Forums
News
Blogs
Features
Site
Home
»
Mailing list archives
»
linux-kernel
»
2008
»
May
»
6
Re: [PATCH] RTC: rtc_time_to_tm: use unsigned arithmetic
view
thread
Previous message: [
thread
] [
date
] [
author
]
Next message: [
thread
] [
date
] [
author
]
[view in full thread]
From: Dmitri Vorobiev
Subject:
Re: [PATCH] RTC: rtc_time_to_tm: use unsigned arithmetic
Date: Tuesday, May 6, 2008 - 3:50 pm
Maciej W. Rozycki пишет:
quoted text
> The input argument to rtc_time_to_tm() is unsigned as well as are members > of the output structure. However signed arithmetic is used within for > calculations leading to incorrect results for input values outside the > signed positive range. If this happens the time of day returned is out of > range. > > Found the problem when fiddling with the RTC and the driver where year > was set to an unexpectedly large value like 2070, e.g.: > > rtc0: setting system clock to 2070-01-01 1193046:71582832:26 UTC (3155760954) > > while it should be: > > rtc0: setting system clock to 2070-01-01 00:15:54 UTC (3155760954) > > Changing types to unsigned fixes the problem. > > Signed-off-by: Maciej W. Rozycki <macro@linux-mips.org> > --- > Tested on 64-bit MIPS. Please apply. > > Maciej > > patch-2.6.26-rc1-20080505-rtc-time-unsigned-11 > diff -up --recursive --new-file linux-2.6.26-rc1-20080505.macro/drivers/rtc/rtc-lib.c linux-2.6.26-rc1-20080505/drivers/rtc/rtc-lib.c > --- linux-2.6.26-rc1-20080505.macro/drivers/rtc/rtc-lib.c 2007-07-10 04:56:26.000000000 +0000 > +++ linux-2.6.26-rc1-20080505/drivers/rtc/rtc-lib.c 2008-05-05 02:37:38.000000000 +0000 > @@ -51,7 +51,7 @@ EXPORT_SYMBOL(rtc_year_days); > */ > void rtc_time_to_tm(unsigned long time, struct rtc_time *tm) > { > - register int days, month, year; > + register unsigned int days, month, year;
Does it make any sense to use the `register' keyword nowadays? Dmitri --
unsubscribe notice
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to
majordomo@vger.kernel.org
More majordomo info at
http://vger.kernel.org/majordomo-info.html
Please read the FAQ at
http://www.tux.org/lkml/
Previous message: [
thread
] [
date
] [
author
]
Next message: [
thread
] [
date
] [
author
]
Messages in current thread:
[PATCH] RTC: rtc_time_to_tm: use unsigned arithmetic
, Maciej W. Rozycki
, (Tue May 6, 3:31 pm)
Re: [PATCH] RTC: rtc_time_to_tm: use unsigned arithmetic
, Dmitri Vorobiev
, (Tue May 6, 3:50 pm)
Re: [PATCH] RTC: rtc_time_to_tm: use unsigned arithmetic
, Maciej W. Rozycki
, (Tue May 6, 6:11 pm)
Navigation
Mailing list archives
Recent posts
Popular discussions
linux-kernel
:
Ingo Molnar
Re: [PATCH 0/3] v2 Make hierarchical RCU less IPI-happy and add more tracing
Jeremy Fitzhardinge
Re: Linux 2.6.28.10 and Linux 2.6.29.6 XEN Guest Support Broken x86_64 in BUILD
Nick Piggin
Re: [patch] CFS (Completely Fair Scheduler), v2
Gary Hade
Re: [PATCH 0/5][RFC] Physical PCI slot objects
Dave Johnson
Re: expected behavior of PF_PACKET on NETIF_F_HW_VLAN_RX device?
linux-netdev
:
Arnd Bergmann
Re: 64-bit net_device_stats
Stephens, Allan
RE: [PATCH]: tipc: Fix oops on send prior to entering networked mode
frank.blaschka
[patch 3/5] [PATCH] qeth: support z/VM VSWITCH Port Isolation
Wu Fengguang
Re: [PATCH] dm9601: handle corrupt mac address
David Miller
Re: [PATCH net-2.6.24] Fix refcounting problem with netif_rx_reschedule()
git
:
Junio C Hamano
Re: [PATCH] [RFC] add Message-ID field to log on git-am operation
Junio C Hamano
Re: Handling large files with GIT
Karl
Re: [ANNOUNCE] pg - A patch porcelain for GIT
Josh Triplett
Re: [RFC][PATCH 00/10] Sparse: Git's "make check" target
Pierre Habouzit
Re: [PATCH] git-daemon: more powerful base-path/user-path settings, using formats.
git-commits-head
:
Linux Kernel Mailing List
MIPS: RBTX4939: Fix IOC pin-enable register updating
Linux Kernel Mailing List
regulator: update email address for Liam Girdwood
Linux Kernel Mailing List
[SCSI] ipr: add message to error table
Linux Kernel Mailing List
powerpc/32: Wire up the trampoline code for kdump
Linux Kernel Mailing List
USB: omap_udc: sync with OMAP tree
openbsd-misc
:
Josh Grosse
Re: error : pkg add phpMyAdmin
Brian Candler
Re: OBSD's perspective on SELinux
Jacob Meuser
Re: /dev/audio: Device busy
David Vasek
Re: Inexpensive, low power, "wall wart" computer
William Boshuck
Re: Richard Stallman...
Colocation donated by:
Syndicate