Re: acpi_cpu_freq_init warning...

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Thomas Renninger
Date: Tuesday, May 6, 2008 - 8:44 am

On Tue, 2008-05-06 at 15:29 +0900, OGAWA Hirofumi wrote:

Venkatesh Greg, should this patch also go into 2.6.25 stable kernel?
Not 100% sure, but IIRC Jiri reported the same problem on a 2.6.25
kernel.

OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>


[PATCH] Fix bogus warning in sysdev_driver_register()

        if ((drv->entry.next != drv->entry.prev) ||
            (drv->entry.next != NULL)) {

warns list_empty(&drv->entry).

Signed-off-by: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
---

 drivers/base/sys.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff -puN drivers/base/sys.c~fix-sys-bogus-warning drivers/base/sys.c
--- linux-2.6/drivers/base/sys.c~fix-sys-bogus-warning  2008-05-06 14:30:42.000000000 +0900
+++ linux-2.6-hirofumi/drivers/base/sys.c       2008-05-06 14:30:45.000000000 +0900
@@ -175,7 +175,7 @@ int sysdev_driver_register(struct sysdev
        }
 
        /* Check whether this driver has already been added to a class. */
-       if ((drv->entry.next != drv->entry.prev) ||
+       if ((drv->entry.next != drv->entry.prev) &&
            (drv->entry.next != NULL)) {
                printk(KERN_WARNING "sysdev: class %s: driver (%p) has already"
                        " been registered to a class, something is wrong, but "
_
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
acpi_cpu_freq_init warning..., Yinghai Lu, (Mon May 5, 7:51 pm)
Re: acpi_cpu_freq_init warning..., OGAWA Hirofumi, (Mon May 5, 11:29 pm)
Re: acpi_cpu_freq_init warning..., Greg KH, (Mon May 5, 11:47 pm)
Re: acpi_cpu_freq_init warning..., OGAWA Hirofumi, (Tue May 6, 12:13 am)
Re: acpi_cpu_freq_init warning..., Linus Torvalds, (Tue May 6, 7:47 am)
Re: acpi_cpu_freq_init warning..., Thomas Renninger, (Tue May 6, 8:44 am)
Re: acpi_cpu_freq_init warning..., OGAWA Hirofumi, (Tue May 6, 12:02 pm)
Re: acpi_cpu_freq_init warning..., Greg KH, (Tue May 6, 1:20 pm)
Re: acpi_cpu_freq_init warning..., Linus Torvalds, (Tue May 6, 1:27 pm)
Re: acpi_cpu_freq_init warning..., Greg KH, (Tue May 6, 2:38 pm)