Re: x86: Clean up computation of HPET .mult variables

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Carlos R. Mafra
Date: Monday, May 5, 2008 - 7:13 pm

On Mon  5.May'08 at 16:58:08 -0700, Daniel Walker wrote:

Ok, but they take the frequency as the input while the "natural" variable
we have is the period, because that's what we get from the hardware (at
least for the HPET, if I understood it correctly).

If I want to use clocksource_hz2mult then I have
to do one more operation (to find the frequency) before calling it (and
that's what the other part of the patch which you didn't quote is
actually doing).

So the savings in my patch is due to using the period directly, and
not the frequency. That's what my idea was, so if you object then
my attempt was a failure and should be forgotten :-)

Or maybe I should create a clocksource_period2mult to replace 
clocksource_hz2mult and save the extra operation in more places too?




--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
x86: Clean up computation of HPET .mult variables, Carlos R. Mafra, (Mon May 5, 4:11 pm)
Re: x86: Clean up computation of HPET .mult variables, Daniel Walker, (Mon May 5, 4:58 pm)
Re: x86: Clean up computation of HPET .mult variables, Carlos R. Mafra, (Mon May 5, 7:13 pm)
Re: x86: Clean up computation of HPET .mult variables, Daniel Walker, (Mon May 5, 8:23 pm)
Re: x86: Clean up computation of HPET .mult variables, Carlos R. Mafra, (Tue May 6, 5:59 am)
Re: x86: Clean up computation of HPET .mult variables, Carlos R. Mafra, (Tue May 6, 6:13 am)
Re: x86: Clean up computation of HPET .mult variables, Daniel Walker, (Tue May 6, 9:21 am)
Re: rtc-cmos.c: Build fix, Carlos R. Mafra, (Tue May 6, 11:51 am)
Re: x86: Clean up computation of HPET .mult variables, Carlos R. Mafra, (Tue May 6, 1:50 pm)
Re: x86: Clean up computation of HPET .mult variables, Daniel Walker, (Tue May 6, 7:17 pm)
Re: x86: Clean up computation of HPET .mult variables, Carlos R. Mafra, (Tue May 6, 8:39 pm)
Re: x86: Clean up computation of HPET .mult variables, Daniel Walker, (Tue May 6, 9:21 pm)
Re: rtc-cmos.c: Build fix, Ingo Molnar, (Wed May 7, 12:10 am)
Re: x86: Clean up computation of HPET .mult variables, Ingo Molnar, (Wed May 7, 12:13 am)
Re: rtc-cmos.c: Build fix, Andrew Morton, (Wed May 7, 2:31 pm)
Re: rtc-cmos.c: Build fix, Ingo Molnar, (Fri May 9, 1:32 am)
Re: rtc-cmos.c: Build fix, Carlos R. Mafra, (Fri May 9, 5:33 am)