On Sun, 4 May 2008 23:42:46 -0400 Ulrich Drepper <drepper@redhat.com> wrote:
In kernel world, the abbreviation "rmap" means "reverse mapping". I think
"flags_remapping" would be a better identifier here.
hm, that looks expensive. The compiler will need to generate a deref of m
and rf multiple times around the loop. Copying them into locals does
improve that a lot.
I'm only on [1/18] so I don't know how often this code gets executed. If
it's "on each open" then ouch, perhaps it might even be worth investigating a
table-based implementation.
Also: sorry, but ugh-at-the-naming. We don't *gain* anything from having
idenitifers called f, of, m, n and rf. And we lose quite a lot in
readability and understandability. It would be much nicer to invest a
little bit more typing-time here, IMO.
--