I'm somewhat ignorant about what this code is attempting to do, but with
some quick poking around (m68knommu, blackfin) seems to suggest that
other architectures don't do this, while others (v850) have almost
exactly the same code (although they are somewhat smarter and are
careful not to flush the whole cache).

At the very least, it seems like there is some work in this area needed.

Steve

quoted text
> -----Original Message-----
> From: John Williams [mailto:john.williams@petalogix.com]
> Sent: Monday, May 05, 2008 4:34 PM
> To: Stephen Neuendorffer
> Cc: monstr@seznam.cz; linux-kernel@vger.kernel.org; arnd@arndb.de;
linux-arch@vger.kernel.org; John
quoted text
> Linn; matthew@wil.cx; will.newton@gmail.com; drepper@redhat.com;
microblaze-uclinux@itee.uq.edu.au;
quoted text
> grant.likely@secretlab.ca; Michal Simek
> Subject: RE: [PATCH 07/56] microblaze_v2: Signal support
> 
> On Mon, 2008-05-05 at 14:32 -0700, Stephen Neuendorffer wrote:
> > (multiple places)  can this code (and flush_cache_sigtramp()) go
away?
quoted text
> >
> > +#if 0
> > +		flush_cache_sigtramp((unsigned long)frame->tramp);
> > +#endif
> 
> You have to icache_invalidate the sigtramp because you are writing
into
quoted text
> memory that will shortly be executed.
> 
> I'm not sure why this is #if'd away in the first place?
> 
> John
> 
> 


--
unsubscribe notice
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/