login
Header Space

 
 

Re: [-mm][PATCH 3/4] Add rlimit controller accounting and control

Score:
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Balbir Singh <balbir@...>
Cc: <linux-mm@...>, <skumar@...>, <yamamoto@...>, <menage@...>, <lizf@...>, <linux-kernel@...>, <rientjes@...>, <xemul@...>, <balbir@...>, <kamezawa.hiroyu@...>
Date: Monday, May 5, 2008 - 6:24 pm

On Sun, 04 May 2008 03:08:14 +0530
Balbir Singh <balbir@linux.vnet.ibm.com> wrote:


I worry a bit about all the conversion between page-counts and byte-counts
in this code.

For example, what happens if a process sits there increasing its rss with
sbrk(4095) or sbrk(4097) or all sorts of other scenarios?  Do we get in a
situation in which the accounting is systematically wrong?

Worse, do we risk getting into that situation in the future, as unrelated
changes are made to the surrounding code?

IOW, have we chosen the best, most maintainable representation for these
things?

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[-mm][PATCH 0/4] Add rlimit controller to cgroups (v3), Balbir Singh, (Sat May 3, 5:37 pm)
Re: [-mm][PATCH 0/4] Add rlimit controller to cgroups (v3), KAMEZAWA Hiroyuki, (Tue May 6, 9:09 pm)
[-mm][PATCH 4/4] Add rlimit controller documentation, Balbir Singh, (Sat May 3, 5:38 pm)
Re: [-mm][PATCH 3/4] Add rlimit controller accounting and co..., Andrew Morton, (Mon May 5, 6:24 pm)
[-mm][PATCH 1/4] Setup the rlimit controller, Balbir Singh, (Sat May 3, 5:37 pm)
Re: [-mm][PATCH 1/4] Setup the rlimit controller, Li Zefan, (Mon May 5, 9:31 pm)
Re: [-mm][PATCH 1/4] Setup the rlimit controller, Balbir Singh, (Tue May 6, 4:15 am)
Re: [-mm][PATCH 1/4] Setup the rlimit controller, Andrew Morton, (Mon May 5, 6:11 pm)
Re: [-mm][PATCH 1/4] Setup the rlimit controller, Balbir Singh, (Mon May 5, 11:40 pm)
speck-geostationary