login
Header Space

 
 

Re: [2.6 patch] #if 0 hpet_unregister()

Previous thread: [2.6 patch] proper prototype for acpi_processor_tstate_has_changed() by Adrian Bunk on Monday, May 5, 2008 - 2:28 pm. (2 messages)

Next thread: [2.6 patch] tpm_bios.c: make 2 structs static by Adrian Bunk on Monday, May 5, 2008 - 2:28 pm. (1 message)
To: Thomas Gleixner <tglx@...>, Clemens Ladisch <clemens@...>
Cc: <linux-kernel@...>, Andrew Morton <akpm@...>
Date: Monday, May 5, 2008 - 2:28 pm

This patch #if 0's the unused hpet_unregister().

Signed-off-by: Adrian Bunk &lt;bunk@kernel.org&gt;
Acked-by: Clemens Ladisch &lt;clemens@ladisch.de&gt;

---

This patch has been sent on:
- 23 Apr 2008
- 14 Apr 2008
- 31 Mar 2008
- 1 Mar 2008

 drivers/char/hpet.c |    2 ++
 1 file changed, 2 insertions(+)

addfb1ea425cb7e01ddd99fd921c6ca42cc6840b foobar
diff --git a/drivers/char/hpet.c b/drivers/char/hpet.c
index 465ad35..98ffdcc 100644
--- a/drivers/char/hpet.c
+++ b/drivers/char/hpet.c
@@ -619,6 +619,7 @@ static inline int hpet_tpcheck(struct hpet_task *tp)
 	return -ENXIO;
 }
 
+#if 0
 int hpet_unregister(struct hpet_task *tp)
 {
 	struct hpet_dev *devp;
@@ -648,6 +649,7 @@ int hpet_unregister(struct hpet_task *tp)
 
 	return 0;
 }
+#endif  /*  0  */
 
 static ctl_table hpet_table[] = {
 	{


--
To: Adrian Bunk <bunk@...>
Cc: Thomas Gleixner <tglx@...>, Clemens Ladisch <clemens@...>, <linux-kernel@...>, Andrew Morton <akpm@...>
Date: Monday, May 5, 2008 - 4:33 pm

Hm...what about Documentation/hpet.txt, where it is written:

The kernel API has three interfaces exported from the driver:

	hpet_register(struct hpet_task *tp, int periodic)
	hpet_unregister(struct hpet_task *tp)
	hpet_control(struct hpet_task *tp, unsigned int cmd, unsigned long arg)

Maybe someone could update that file too, to help anyone who wants to
learn about hpet ( hpet_register(...) and hpet_control(...) don't even
exist anymore in the kernel)
--
Previous thread: [2.6 patch] proper prototype for acpi_processor_tstate_has_changed() by Adrian Bunk on Monday, May 5, 2008 - 2:28 pm. (2 messages)

Next thread: [2.6 patch] tpm_bios.c: make 2 structs static by Adrian Bunk on Monday, May 5, 2008 - 2:28 pm. (1 message)
speck-geostationary