login
Login / Register
Header Space

 
 

Home » Mailing list archives » linux-kernel » 2008 » May » 5

[PATCH] bay: Exit if notify handler cannot be installed

Score:
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Holger Macht <hmacht@...>
To: <linux-acpi@...>
Cc: <linux-kernel@...>, <kristen.c.accardi@...>
Subject: [PATCH] bay: Exit if notify handler cannot be installed
Date: Monday, May 5, 2008 - 4:25 pm

If acpi_install_notify_handler() for a bay device fails, the bay driver is
superfluous. Most likely, another driver (like libata) is already caring
about this device anyway. Furthermore,
register_hotplug_dock_device(acpi_handle) from the dock driver must not be
called twice with the same handler. So clean up and exit.

Signed-off-by: Holger Macht <hmacht@suse.de>
---

diff --git a/drivers/acpi/bay.c b/drivers/acpi/bay.c
index d2fc941..ce9038f 100644
--- a/drivers/acpi/bay.c
+++ b/drivers/acpi/bay.c
@@ -311,6 +311,7 @@ static int bay_add(acpi_handle handle, int id)
 			bay_notify, new_bay);
 	if (ACPI_FAILURE(status)) {
 		printk(KERN_ERR PREFIX "Error installing bay notify handler\n");
+		goto bay_add_err;
 	}
 
 	/* if we are on a dock station, we should register for dock

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH] bay: Exit if notify handler cannot be installed, Holger Macht, (Mon May 5, 4:25 pm)
Re: [PATCH] bay: Exit if notify handler cannot be installed, Holger Macht, (Tue May 6, 5:15 am)
Re: [PATCH] bay: Exit if notify handler cannot be installed, Shaohua Li, (Tue May 6, 5:23 am)
Re: [PATCH] bay: Exit if notify handler cannot be installed, Henrique de Moraes Holschuh..., (Tue May 6, 11:18 am)
Re: [PATCH] bay: Exit if notify handler cannot be installed, Shaohua Li, (Tue May 6, 9:04 pm)
Re: [PATCH] bay: Exit if notify handler cannot be installed, Henrique de Moraes Holschuh..., (Tue May 6, 9:13 pm)
Re: [PATCH] bay: Exit if notify handler cannot be installed, Shaohua Li, (Tue May 6, 9:27 pm)
Re: [PATCH] bay: Exit if notify handler cannot be installed, Henrique de Moraes Holschuh..., (Wed May 7, 8:37 am)
Re: [PATCH] bay: Exit if notify handler cannot be installed, Matthew Garrett, (Wed May 7, 10:17 am)
Re: [PATCH] bay: Exit if notify handler cannot be installed, Holger Macht, (Wed May 7, 9:05 am)
Re: [PATCH] bay: Exit if notify handler cannot be installed, Henrique de Moraes Holschuh..., (Wed May 7, 8:43 am)
Re: [PATCH] bay: Exit if notify handler cannot be installed, Holger Macht, (Tue May 6, 1:13 pm)
Re: [PATCH] bay: Exit if notify handler cannot be installed, Alan Cox, (Tue May 6, 11:20 am)
Re: [PATCH] bay: Exit if notify handler cannot be installed, Henrique de Moraes Holschuh..., (Tue May 6, 11:39 am)
Re: [PATCH] bay: Exit if notify handler cannot be installed, Holger Macht, (Tue May 6, 1:17 pm)
Re: [PATCH] bay: Exit if notify handler cannot be installed, Alan Cox, (Tue May 6, 11:49 am)
Re: [PATCH] bay: Exit if notify handler cannot be installed, Holger Macht, (Tue May 6, 5:33 am)
Re: [PATCH] bay: Exit if notify handler cannot be installed, Holger Macht, (Tue May 6, 5:35 am)
Re: [PATCH] bay: Exit if notify handler cannot be installed, Shaohua Li, (Tue May 6, 9:03 pm)
Re: [PATCH] bay: Exit if notify handler cannot be installed, Henrique de Moraes Holschuh..., (Tue May 6, 11:24 am)
Re: [PATCH] bay: Exit if notify handler cannot be installed, Holger Macht, (Tue May 6, 1:12 pm)

Mail archive search
Enter your search terms.
Optionally limit your search to a specific mailing list.
advanced
Recent Tags
more tags
Colocation donated by:
Who's online
There are currently 4 users and 957 guests online.

Online users

Syndicate
Syndicate content
© 2007 KernelTrap.  |  Powered by Drupal.  |  Legal statement.
speck-geostationary