login
Login
/
Register
Search
Forums
News
Blogs
Features
Site
Home
»
Mailing list archives
»
linux-kernel
»
2008
»
May
»
5
Re: [PATCH] i386: Execute stack overflow warning on interrupt stack II
view
thread
!MAILaRCHIVE_VOTE_RePLACE
Previous message: [
thread
] [
date
] [
author
]
Next message: [thread] [
date
] [
author
]
[view in full thread]
From:
Eric Sandeen <sandeen@...>
To: Thomas Gleixner <tglx@...>
Cc: Andi Kleen <andi@...>, <linux-kernel@...>, <mingo@...>
Subject:
Re: [PATCH] i386: Execute stack overflow warning on interrupt stack II
Date: Monday, May 5, 2008 - 9:13 am
Thomas Gleixner wrote:
quoted text
> On Mon, 5 May 2008, Andi Kleen wrote: >> Thomas Gleixner wrote: >>> On Fri, 2 May 2008, Andi Kleen wrote: >>>> +static void stack_overflow(void) >>>> +{ >>>> + printk("low stack detected by irq handler\n"); >>> Needs a KERN_ERR >> Just moving code. If there is one added it should be in another patch. > > Err, you are not moving code. The printk is pretty different and > adding the KERN_xx in the same go is nothing which makes the patch > harder to understand. > >> Besides if anything it's a KERN_WARN I guess. > > KERN_WARN is fine, even if I consider a stack overflow as an error.
But it hasn't overflowed yet. It's a warning about being *close* - not an error. -Eric --
unsubscribe notice
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to
majordomo@vger.kernel.org
More majordomo info at
http://vger.kernel.org/majordomo-info.html
Please read the FAQ at
http://www.tux.org/lkml/
Previous message: [
thread
] [
date
] [
author
]
Next message: [thread] [
date
] [
author
]
Messages in current thread:
[PATCH] i386: Execute stack overflow warning on interrupt st...
, Andi Kleen
, (Fri May 2, 5:18 am)
Re: [PATCH] i386: Execute stack overflow warning on interrup...
, Eric Sandeen
, (Mon May 5, 9:42 am)
Re: [PATCH] i386: Execute stack overflow warning on interrup...
, Andi Kleen
, (Mon May 5, 9:47 am)
Re: [PATCH] i386: Execute stack overflow warning on interrup...
, Andi Kleen
, (Fri May 2, 5:45 am)
Re: [PATCH] i386: Execute stack overflow warning on interrup...
, Thomas Gleixner
, (Mon May 5, 5:59 am)
Re: [PATCH] i386: Execute stack overflow warning on interrup...
, Andi Kleen
, (Mon May 5, 6:17 am)
Re: [PATCH] i386: Execute stack overflow warning on interrup...
, Thomas Gleixner
, (Mon May 5, 8:39 am)
Re: [PATCH] i386: Execute stack overflow warning on interrup...
, Andi Kleen
, (Mon May 5, 9:29 am)
Re: [PATCH] i386: Execute stack overflow warning on interrup...
, Pekka Enberg
, (Mon May 5, 9:42 am)
Re: [PATCH] i386: Execute stack overflow warning on interrup...
, Andi Kleen
, (Mon May 5, 9:45 am)
Re: [PATCH] i386: Execute stack overflow warning on interrup...
, Eric Sandeen
, (Mon May 5, 9:13 am)
Re: [PATCH] i386: Execute stack overflow warning on interrup...
, Jiri Slaby
, (Fri May 2, 5:45 am)
Re: [PATCH] i386: Execute stack overflow warning on interrup...
, Andi Kleen
, (Fri May 2, 5:48 am)
Navigation
Create content
Mailing list archives
Recent posts
Popular discussions
linux-kernel
:
Greg KH
Re: Dual-Licensing Linux Kernel with GPL V2 and GPL V3
Heiko Carstens
Re: -mm merge plans for 2.6.23 -- sys_fallocate
Tony Lindgren
[PATCH 37/90] ARM: OMAP: MPUIO wake updates
Greg Kroah-Hartman
[PATCH 001/196] Chinese: Add the known_regression URI to the HOWTO
git
:
linux-netdev
:
Gerrit Renker
[PATCH 27/37] dccp: Integration of dynamic feature activation - part 2 (server side)
David Miller
[GIT]: Networking
David Miller
Re: [PATCH] pkt_sched: Destroy gen estimators under rtnl_lock().
Benjamin Herrenschmidt
Re: powerpc allmodconfig
openbsd-misc
:
Colocation donated by:
Who's online
There are currently
2 users
and
917 guests
online.
Online users
billprice73
shante88996
Syndicate