Re: changeset: Make forced module loading optional

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Rusty Russell <rusty@...>
Cc: <linux-kernel@...>, Jon Masters <jonathan@...>, Sam Ravnborg <sam@...>
Date: Monday, May 5, 2008 - 1:05 am

On Mon, 5 May 2008, Rusty Russell wrote:

I don't use modules much, so many of my kernels tend to have modules off 
entirely. However, the Intel wireless drivers used to not work when 
built-in (fixed now, but I still had a legacy config), so my laptop had 
modules enabled, and MODVERSIONS set.

And I don't build initrd's etc crap, very much on purpose. I want to 
replace the kernel, nothing else, so my /etc/grub.conf file just replaces 
the distro kernel with my own, and keeps everything else untouched.


Wouldn't help one whit, and is against my rules anyway. See above. I want 
my own kernel, no other changes. That means that I run the distro initrd, 
which has its modules for bringing stuff up with distro kernels.

And quite frankly, when I finally figured out what was going on, I was 
like *WHAT THE HELL*. That kernel/module.c code was absolute and utter 
crap in accepting modules that neither matched the kernel version 
signature (because it had CONFIG_MODVERSIONS) *nor* the actual versioned 
symbols (because the distro modules had been built without 
CONFIG_MODVERSIONS).

So no, I'm not at all interested in blowing away old modules. I'm 
interested in having a module loader that isn't complete and utter crap 
and bypasses all the sanity checks that it has.

Which is what that changeset basically does.

People can still set CONFIG_MODULE_LOAD_FORCE, but quite frankly, I 
suspect that anybody who does that is just insane and/or works with 
proprietary and broken modules. So it's off by default, and hopefully no 
distro will ever set it.

			Linus
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Re: changeset: Make forced module loading optional, Rusty Russell, (Mon May 5, 12:55 am)
Re: changeset: Make forced module loading optional, Jan Engelhardt, (Mon May 5, 2:35 am)
Re: changeset: Make forced module loading optional, Linus Torvalds, (Mon May 5, 1:05 am)
Re: changeset: Make forced module loading optional, Jan Engelhardt, (Mon May 5, 2:43 am)
Re: changeset: Make forced module loading optional, Dave Jones, (Mon May 5, 11:32 am)
Re: changeset: Make forced module loading optional, Jan Engelhardt, (Mon May 5, 12:01 pm)
Re: changeset: Make forced module loading optional, Linus Torvalds, (Mon May 5, 11:48 am)
Re: changeset: Make forced module loading optional, Linus Torvalds, (Mon May 5, 10:37 am)
Re: changeset: Make forced module loading optional, Jeff Garzik, (Mon May 5, 10:50 am)
Re: changeset: Make forced module loading optional, Linus Torvalds, (Mon May 5, 11:01 am)
Re: changeset: Make forced module loading optional, Linus Torvalds, (Mon May 5, 11:08 am)
Re: changeset: Make forced module loading optional, Rusty Russell, (Mon May 5, 1:35 am)
Re: changeset: Make forced module loading optional, Linus Torvalds, (Mon May 5, 1:07 pm)
Re: changeset: Make forced module loading optional, Rusty Russell, (Mon May 5, 2:42 pm)
Re: changeset: Make forced module loading optional, David Miller, (Mon May 5, 3:47 pm)