Re: [-mm][PATCH 3/5] change function prototype of shrink_zone()

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: minchan Kim
Date: Sunday, May 4, 2008 - 9:42 pm

>  -static unsigned long shrink_zone(int priority, struct zone *zone,

I am not sure this is right.
I might be wrong if this patch is depended on another patch.

As I see, shrink_zone always return 0 in your patch.

If it is right, I think that return value is useless. It is better
that we change function return type to "void"
Also, we have to change functions that call shrink_zone properly. ex)
balance_pgdat, __zone_reclaim
That functions still use number of shrink_zone's reclaim page

-- 
Thanks,
barrios
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[-mm][PATCH 0/5] mm: page reclaim throttle v6, KOSAKI Motohiro, (Sun May 4, 5:53 am)
[-mm][PATCH 2/5] introduce get_vm_event(), KOSAKI Motohiro, (Sun May 4, 5:57 am)
[-mm][PATCH 4/5] core of reclaim throttle, KOSAKI Motohiro, (Sun May 4, 5:59 am)
Re: [-mm][PATCH 4/5] core of reclaim throttle, KOSAKI Motohiro, (Sun May 4, 6:12 am)
Re: [-mm][PATCH 0/5] mm: page reclaim throttle v6, KOSAKI Motohiro, (Sun May 4, 7:38 am)
Re: [-mm][PATCH 3/5] change function prototype of shrink_z ..., minchan Kim, (Sun May 4, 9:42 pm)
Re: [-mm][PATCH 4/5] core of reclaim throttle, minchan Kim, (Sun May 4, 10:21 pm)
Re: [-mm][PATCH 1/5] fix overflow problem of do_try_to_fre ..., Nishanth Aravamudan, (Mon May 5, 1:12 am)
Re: [-mm][PATCH 4/5] core of reclaim throttle, KOSAKI Motohiro, (Mon May 5, 1:24 am)
Re: [-mm][PATCH 4/5] core of reclaim throttle, minchan Kim, (Mon May 5, 1:32 am)
Re: [-mm][PATCH 2/5] introduce get_vm_event(), Rik van Riel, (Mon May 5, 2:47 pm)
Re: [-mm][PATCH 4/5] core of reclaim throttle, Rik van Riel, (Mon May 5, 2:51 pm)
Re: [-mm][PATCH 4/5] core of reclaim throttle, KOSAKI Motohiro, (Mon May 5, 3:23 pm)
Re: [-mm][PATCH 4/5] core of reclaim throttle, Rik van Riel, (Mon May 5, 5:43 pm)
Re: [-mm][PATCH 4/5] core of reclaim throttle, KOSAKI Motohiro, (Mon May 5, 6:01 pm)