Re: [PATCH 00/18] firmware: moving drivers to request_firmware()

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Jeff Garzik <jeff@...>
Cc: <linux-kernel@...>
Date: Saturday, May 31, 2008 - 6:18 pm

On Thu, 2008-06-05 at 18:11 -0400, Jeff Garzik wrote:

I have no intention of removing that.



That I don't care about. If you can load modules, you can handle
request_firmware().


That would be a useful thing; currently the built-in firmwares cannot be
overridden but it wouldn't be hard to implement. Suggest it in 'diff -u'
form and it might just happen.


I don't think we have consensus on that, but as I said: post patches and
let's see if they get merged.


And binary isn't the preferred form either. We can cope with binary, but
it's not appropriate in the kernel source tree, imho.

When I make the shadow tree which contains the results of 'make
firmware_install', that'll have the binaries.


All these are true, but you're still missing the point that as I have it
it's already a _lot_ easier to process than when it was arrays of __be32
in some header file. I don't want to change to binary blobs as part of
what I'm doing this week. That's a _separate_ issue, and I'm not even
sure it's a goal I agree with.



I disagree. But feel free to post patches which get applied and prove me
wrong. I'm not going to object if you want to go convert a few more
drivers.

-- 
dwmw2

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Re: [PATCH 00/18] firmware: moving drivers to request_firmwa..., David Woodhouse, (Sat May 31, 6:18 pm)
Re: [PATCH 00/18] firmware: moving drivers to request_firmwa..., Arkadiusz Miskiewicz, (Thu Jun 5, 6:07 am)
[PATCH 18/18] whiteheat: use request_firmware(), David Woodhouse, (Fri May 30, 6:35 pm)
[PATCH 17/18] ti_usb_3410_5052: use request_firmware(), David Woodhouse, (Fri May 30, 11:49 am)
[PATCH 14/18] keyspan_pda: use request_firmware(), David Woodhouse, (Fri May 30, 8:15 am)
[PATCH 10/18] ihex.h: binary representation of ihex records, David Woodhouse, (Fri May 30, 6:57 am)
[PATCH 09/18] ttusb-budget: use request_firmware(), David Woodhouse, (Thu May 29, 12:50 pm)
[PATCH 08/18] kaweth: use request_firmware(), David Woodhouse, (Thu May 29, 10:17 am)
[PATCH 07/18] smctr: use request_firmware(), David Woodhouse, (Thu May 29, 9:39 am)
[PATCH 03/18] firmware: Add 'firmware_install' make target, David Woodhouse, (Thu May 29, 4:01 am)
[PATCH 02/18] firmware: Add CONFIG_BUILTIN_FIRMWARE option, David Woodhouse, (Fri May 23, 8:58 am)