Home » Mailing list archives » linux-kernel » 2008 » May » 31

[PATCH] firewire: fw-ohci: clear LinkControl register when enabling the chip

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Stefan Richter <stefanr@...>
To: <linux1394-devel@...>
Cc: <linux-kernel@...>
Subject: [PATCH] firewire: fw-ohci: clear LinkControl register when enabling the chip
Date: Saturday, May 31, 2008 - 7:08 pm

We want the rcvPhyPkt bit in LinkControl off before we start using the
chip.  However, the spec says that the reset value of it is undefined.
Hence switch it (and all other bits while we are at it) explicitly off.

https://bugzilla.redhat.com/show_bug.cgi?id=244576#c48 shows that for
example the nForce2 integrated FireWire controller seems to have it on
by default.

Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
---
 drivers/firewire/fw-ohci.c |    1 +
 1 file changed, 1 insertion(+)

Index: linux/drivers/firewire/fw-ohci.c
===================================================================
--- linux.orig/drivers/firewire/fw-ohci.c
+++ linux/drivers/firewire/fw-ohci.c
@@ -1473,6 +1473,7 @@ static int ohci_enable(struct fw_card *c
 	reg_write(ohci, OHCI1394_HCControlClear,
 		  OHCI1394_HCControl_noByteSwapData);
 
+	reg_write(ohci, OHCI1394_LinkControlClear, ~0);
 	reg_write(ohci, OHCI1394_LinkControlSet,
 		  OHCI1394_LinkControl_rcvSelfID |
 		  OHCI1394_LinkControl_cycleTimerEnable |

-- 
Stefan Richter
-=====-==--- -==- ----=
http://arcgraph.de/sr/

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH] firewire: fw-ohci: clear LinkControl register when e..., Stefan Richter, (Sat May 31, 7:08 pm)
[PATCH] firewire: fw-ohci: disable PHY packet reception into..., Stefan Richter, (Thu Jun 5, 2:49 pm)
Re: [PATCH] firewire: fw-ohci: disable PHY packet reception ..., Jarod Wilson, (Thu Jun 5, 3:10 pm)
[PATCH] firewire: fw-ohci: write selfIDBufferPtr before Link..., Stefan Richter, (Thu Jun 5, 2:50 pm)
Re: [PATCH] firewire: fw-ohci: write selfIDBufferPtr before ..., Kristian , (Fri Jun 13, 9:50 am)
Re: [PATCH] firewire: fw-ohci: write selfIDBufferPtr before ..., Jarod Wilson, (Thu Jun 5, 3:13 pm)