[PATCH] __exit_signal: don't take rcu lock

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Andrew Morton <akpm@...>
Cc: Paul E. McKenney <paulmck@...>, <linux-kernel@...>
Date: Saturday, May 31, 2008 - 12:15 pm

There is no reason for rcu_read_lock() in __exit_signal(). tsk->sighand can
only be changed if tsk does exec, obviously this is not possible.

Signed-off-by: Oleg Nesterov <oleg@tv-sign.ru>

--- 26-rc2/kernel/exit.c~0_ES_NO_RCU	2008-05-26 18:09:12.000000000 +0400
+++ 26-rc2/kernel/exit.c	2008-05-31 20:08:11.000000000 +0400
@@ -84,7 +84,6 @@ static void __exit_signal(struct task_st
 	BUG_ON(!sig);
 	BUG_ON(!atomic_read(&sig->count));
 
-	rcu_read_lock();
 	sighand = rcu_dereference(tsk->sighand);
 	spin_lock(&sighand->siglock);
 
@@ -135,7 +134,6 @@ static void __exit_signal(struct task_st
 	tsk->signal = NULL;
 	tsk->sighand = NULL;
 	spin_unlock(&sighand->siglock);
-	rcu_read_unlock();
 
 	__cleanup_sighand(sighand);
 	clear_tsk_thread_flag(tsk,TIF_SIGPENDING);

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH] __exit_signal: don't take rcu lock, Oleg Nesterov, (Sat May 31, 12:15 pm)