Home » Mailing list archives » linux-kernel » 2008 » May » 30

[PATCH] edd: fix suspicious return of 1 from module_init

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Alexey Dobriyan <adobriyan@...>
To: <akpm@...>
Cc: <linux-kernel@...>
Subject: [PATCH] edd: fix suspicious return of 1 from module_init
Date: Friday, May 30, 2008 - 7:29 pm

Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
---

 drivers/firmware/edd.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/drivers/firmware/edd.c
+++ b/drivers/firmware/edd.c
@@ -753,7 +753,7 @@ edd_init(void)
 
 	if (!edd_num_devices()) {
 		printk(KERN_INFO "EDD information not available.\n");
-		return 1;
+		return -ENODEV;
 	}
 
 	edd_kset = kset_create_and_add("edd", NULL, firmware_kobj);

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH] edd: fix suspicious return of 1 from module_init, Alexey Dobriyan, (Fri May 30, 7:29 pm)