login
Header Space

 
 

Re: [patch 4/4] MIPS: ELF handling - use SELFMAG instead of numeric constant

Score:
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: <akpm@...>, <hpa@...>, <mingo@...>, <ralf@...>, <linux-kernel@...>
Date: Saturday, May 3, 2008 - 6:35 am

[Cyrill Gorcunov - Sat, May 03, 2008 at 02:18:04PM +0400]
| Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com>
| ---
| 
| Index: linux-2.6.git/arch/mips/kernel/vpe.c
| ===================================================================
| --- linux-2.6.git.orig/arch/mips/kernel/vpe.c	2008-04-15 23:01:26.000000000 +0400
| +++ linux-2.6.git/arch/mips/kernel/vpe.c	2008-05-02 21:40:57.000000000 +0400
| @@ -840,7 +840,7 @@ static int vpe_elfload(struct vpe * v)
|  
|  	/* Sanity checks against insmoding binaries or wrong arch,
|  	   weird elf version */
| -	if (memcmp(hdr->e_ident, ELFMAG, 4) != 0
| +	if (memcmp(hdr->e_ident, ELFMAG, SELFMAG) != 0
|  	    || (hdr->e_type != ET_REL && hdr->e_type != ET_EXEC)
|  	    || !elf_check_arch(hdr)
|  	    || hdr->e_shentsize != sizeof(*sechdrs)) {
| 
| -- 
| 
oops, MIPS was not refreshed by whole. This is a fix.
---

From: Cyrill Gorcunov <gorcunov@gmail.com>
Subject: MIPS: ELF handling - use SELFMAG instead of numeric constant

Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com>
---

Index: linux-2.6.git/arch/mips/kernel/vpe.c
===================================================================
--- linux-2.6.git.orig/arch/mips/kernel/vpe.c	2008-04-15 23:01:26.000000000 +0400
+++ linux-2.6.git/arch/mips/kernel/vpe.c	2008-05-03 14:28:47.000000000 +0400
@@ -840,7 +840,7 @@ static int vpe_elfload(struct vpe * v)
 
 	/* Sanity checks against insmoding binaries or wrong arch,
 	   weird elf version */
-	if (memcmp(hdr->e_ident, ELFMAG, 4) != 0
+	if (memcmp(hdr->e_ident, ELFMAG, SELFMAG) != 0
 	    || (hdr->e_type != ET_REL && hdr->e_type != ET_EXEC)
 	    || !elf_check_arch(hdr)
 	    || hdr->e_shentsize != sizeof(*sechdrs)) {
@@ -1107,7 +1107,7 @@ static int vpe_release(struct inode *ino
 		return -ENODEV;
 
 	hdr = (Elf_Ehdr *) v->pbuffer;
-	if (memcmp(hdr->e_ident, ELFMAG, 4) == 0) {
+	if (memcmp(hdr->e_ident, ELFMAG, SELFMAG) == 0) {
 		if (vpe_elfload(v) >= 0) {
 			vpe_run(v);
 		} else {
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Re: [patch 4/4] MIPS: ELF handling - use SELFMAG instead of ..., Cyrill Gorcunov, (Sat May 3, 6:35 am)
speck-geostationary