Re: [PATCH] sched: Move cpu masks from kernel/sched.c into kernel/cpu.c

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Max Krasnyansky <maxk@...>
Cc: <mingo@...>, <a.p.zijlstra@...>, <linux-kernel@...>, <menage@...>, <rostedt@...>, <maxk@...>
Date: Thursday, May 29, 2008 - 7:26 pm

Max wrote:

I don't think this is possible.  It must affect the size.

The patch moves kernel/cpu.o from being included only if CONFIG_SMP,
to being included always:

     obj-y     = sched.o fork.o exec_domain.o panic.o printk.o profile.o \
    -	    exit.o itimer.o time.o softirq.o resource.o \
    +	    cpu.o exit.o itimer.o time.o softirq.o resource.o \
		sysctl.o capability.o ptrace.o timer.o user.o \
		signal.o sys.o kmod.o workqueue.o pid.o \
		rcupdate.o extable.o params.o posix-timers.o \
    @@ -27,7 +27,7 @@ obj-$(CONFIG_RT_MUTEXES) += rtmutex.o
     obj-$(CONFIG_DEBUG_RT_MUTEXES) += rtmutex-debug.o
     obj-$(CONFIG_RT_MUTEX_TESTER) += rtmutex-tester.o
     obj-$(CONFIG_GENERIC_ISA_DMA) += dma.o
    -obj-$(CONFIG_SMP) += cpu.o spinlock.o
    +obj-$(CONFIG_SMP) += spinlock.o

The kernel/cpu.o object file is non-empty; it has size,
perhaps 1 or 2 kbytes of text, and a little bit of data.

So adding it to builds which disabled SMP must add to the
size of the resultant kernel, by my thinking anyway.

-- 
                  I won't rest till it's the best ...
                  Programmer, Linux Scalability
                  Paul Jackson <pj@sgi.com> 1.940.382.4214
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Re: [PATCH] sched: Move cpu masks from kernel/sched.c into k..., Paul Jackson, (Thu May 29, 7:26 pm)