Re: [Ksummit-2008-discuss] Fixing the Kernel Janitors project

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: James Bottomley <James.Bottomley@...>
Cc: <ksummit-2008-discuss@...>, linux-kernel <linux-kernel@...>
Date: Thursday, May 29, 2008 - 7:32 am

James Bottomley wrote:
[...]
This particular problem seems fixable. Put something like this in the 
janitor faq:

"Don't create patches that are whitespace-fixes, or similiar attempts to
make the kernel adhere to the CodingStyle without actually changing the 
working code. The reasons are:
* Any patch disturbs others working on the same file. So change must be
   justified by usefulness above mere pretty formatting.
* The maintainer can run the code through pretty-printing software
   _when it won't disrupt other activity_. Such software will do
   a better cleanup job than you can, and with no human effort at.
Please find something more useful to do than whitespace/style
improvements on existing code."

And if they do this anyway, just reject the patch with a pointer to the 
FAQ entry...

Helge Hafting

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[Ksummit-2008-discuss] Fixing the Kernel Janitors project, James Bottomley, (Wed May 28, 1:20 pm)
Re: [Ksummit-2008-discuss] Fixing the Kernel Janitors project, Helge Hafting, (Thu May 29, 7:32 am)
Re: [Ksummit-2008-discuss] Fixing the Kernel Janitors project, James Bottomley, (Thu May 29, 10:26 am)
Re: [Ksummit-2008-discuss] Fixing the Kernel Janitors project, Benjamin Herrenschmidt, (Thu May 29, 2:17 am)
Re: [Ksummit-2008-discuss] Fixing the Kernel Janitors project, Benjamin Herrenschmidt, (Thu May 29, 9:20 pm)
Re: [Ksummit-2008-discuss] Fixing the Kernel Janitors project, Benjamin Herrenschmidt, (Sun Jun 1, 7:56 pm)
Re: [Ksummit-2008-discuss] Fixing the Kernel Janitors project, Benjamin Herrenschmidt, (Thu May 29, 9:25 pm)
RFC: Moving firmware blobs out of the kernel., David Woodhouse, (Thu May 29, 12:15 pm)
Re: RFC: Moving firmware blobs out of the kernel., Benjamin Herrenschmidt, (Thu May 29, 9:22 pm)
Re: [Ksummit-2008-discuss] RFC: Moving firmware blobs out of..., Mauro Carvalho Chehab, (Sun Jun 8, 7:13 am)
Re: [Ksummit-2008-discuss] RFC: Moving firmware blobs out of..., Arnaldo Carvalho de Melo, (Fri May 30, 9:47 am)
Re: RFC: Moving firmware blobs out of the kernel., Jeff Garzik, (Thu May 29, 3:12 pm)
Re: [Ksummit-2008-discuss] RFC: Moving firmware blobs out of..., Benjamin Herrenschmidt, (Thu May 29, 9:27 pm)
Re: RFC: Moving firmware blobs out of the kernel., David Woodhouse, (Thu May 29, 5:18 pm)
Re: [Ksummit-2008-discuss] Fixing the Kernel Janitors project, James Bottomley, (Thu May 29, 10:36 am)
Re: [Ksummit-2008-discuss] Fixing the Kernel Janitors project, Rafael J. Wysocki, (Thu May 29, 4:24 pm)
Re: [Ksummit-2008-discuss] Fixing the Kernel Janitors project, Rafael J. Wysocki, (Mon Jun 2, 6:43 am)
How many contributors are we losing, Luck, Tony, (Fri May 30, 4:23 pm)
Re: How many contributors are we losing, Josh Boyer, (Fri May 30, 9:12 pm)
Re: How many contributors are we losing, Greg KH, (Fri May 30, 4:47 pm)
Re: How many contributors are we losing, Stefan Richter, (Sat May 31, 3:53 pm)
Re: How many contributors are we losing, Willy Tarreau, (Fri May 30, 4:46 pm)