On Wed, May 28, 2008 at 12:20:12PM -0500, James Bottomley wrote:I suspect many of the people contributing to this thread aren't on the kernel-janitors list. They're only seeing janitorial-style patches hit them in the face, and they know they don't like it. Part of the problem is that whitespace fixing patches are treated like they're real patches. We get conflicts with real patches, they're pinged like they're real patches, and the contributors name gets put in the shortlog like it was a real patch. I liked the trivial service that Rusty had setup. Patch started getting conflicts? Dropped. Pinged? By an automated device, not by akpm. We didn't have contributor names back then, but maybe we should anonymise whitespace patches -- just accept that something that could have been done by a machine isn't worth attaching a name to. Also, a lot of the trivial patches don't come across the janitors list first, so shutting the project down will not, IMO, reduce the problem. So, most obvious, but wrong ;-) That's a good idea. We'd all be happier if more people spent time on bug triage, investigation and fixing. There are some of those things going on in the current janitors project, it's just they're drowned out by the noise. I'd like to mention a few. Mark Asselstine has been working to remove the last remnants of cli/sti from the kernel. I believe patches to get rid of them all are now either merged or sitting in trees waiting to be merged. I found him receptive to feedback and willing to sit down and really analyse a driver to figure out what was going on. If he chooses to continue his kernel hacking career, he'll be a great asset. Julia Lawall has a fun tool that spots patterns which are buggy. I've worked on a number of patches with her recently where we compare unsigned integers < 0. Again, we need people to look at the piece of code in context to figure out what the original author meant (not too dissimilar from the coverity reports). -- Intel are signing my paycheques ... these opinions are still mine "Bill, look, we understand that you're interested in selling us this operating system, but compare it to ours. We can't possibly take such a retrograde step." --
| Tarkan Erimer | Re: Dual-Licensing Linux Kernel with GPL V2 and GPL V3 |
| Greg Kroah-Hartman | [PATCH 006/196] Chinese: add translation of oops-tracing.txt |
| Eric Sandeen | Re: [RFC] Heads up on sys_fallocate() |
| YOSHIFUJI Hideaki / | request_module: runaway loop modprobe net-pf-1 (is Re: Linux 2.6.21-rc1) |
git: | |
| Gerrit Renker | [PATCH 0/37] dccp: Feature negotiation - last call for comments |
| Jarek Poplawski | Re: [PATCH] pkt_sched: Destroy gen estimators under rtnl_lock(). |
| Ben Greear | Re: MACVLANs really best solution? How about a bridge with multiple bridge virtual... |
| Rafael J. Wysocki | 2.6.29-rc8: Reported regressions from 2.6.28 |
