Home » Mailing list archives » linux-kernel » 2008 » May » 27

[PATCH 4/8] x86: I/O APIC: Remove redundant LVT0 masking

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Maciej W. Rozycki <macro@...>
To: Ingo Molnar <mingo@...>
Cc: Thomas Gleixner <tglx@...>, H. Peter Anvin <hpa@...>, <linux-kernel@...>
Subject: [PATCH 4/8] x86: I/O APIC: Remove redundant LVT0 masking
Date: Tuesday, May 27, 2008 - 4:19 pm

The LINT0 line of the local APIC is masked in the LVT0 entry in 
check_timer() before this function is ever called.  Removed the redundant 
unmasking for better control.

Signed-off-by: Maciej W. Rozycki <macro@linux-mips.org>
---
patch-2.6.26-rc1-20080505-timer-extint-nolvt0-0
diff -up --recursive --new-file linux-2.6.26-rc1-20080505.macro/arch/x86/kernel/io_apic_32.c linux-2.6.26-rc1-20080505/arch/x86/kernel/io_apic_32.c
--- linux-2.6.26-rc1-20080505.macro/arch/x86/kernel/io_apic_32.c	2008-05-25 02:03:08.000000000 +0000
+++ linux-2.6.26-rc1-20080505/arch/x86/kernel/io_apic_32.c	2008-05-25 16:56:01.000000000 +0000
@@ -1310,9 +1310,6 @@ static void __init setup_ExtINT_IRQ0_pin
 
 	memset(&entry,0,sizeof(entry));
 
-	/* mask LVT0 */
-	apic_write_around(APIC_LVT0, APIC_LVT_MASKED | APIC_DM_EXTINT);
-
 	/*
 	 * We use logical delivery to get the timer IRQ
 	 * to the first CPU.
diff -up --recursive --new-file linux-2.6.26-rc1-20080505.macro/arch/x86/kernel/io_apic_64.c linux-2.6.26-rc1-20080505/arch/x86/kernel/io_apic_64.c
--- linux-2.6.26-rc1-20080505.macro/arch/x86/kernel/io_apic_64.c	2008-05-25 16:56:37.000000000 +0000
+++ linux-2.6.26-rc1-20080505/arch/x86/kernel/io_apic_64.c	2008-05-25 17:00:25.000000000 +0000
@@ -920,9 +920,6 @@ static void __init setup_ExtINT_IRQ0_pin
 
 	memset(&entry, 0, sizeof(entry));
 
-	/* mask LVT0 */
-	apic_write(APIC_LVT0, APIC_LVT_MASKED | APIC_DM_EXTINT);
-
 	/*
 	 * We use logical delivery to get the timer IRQ
 	 * to the first CPU.
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH 4/8] x86: I/O APIC: Remove redundant LVT0 masking, Maciej W. Rozycki, (Tue May 27, 4:19 pm)