[PATCH] scsi: remove CDROM not ready printk

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: <scsi@...>
Cc: <linux-kernel@...>
Date: Tuesday, May 27, 2008 - 3:02 pm

Hello,
   This printk was spamming my dmesg and /var/log/message.  Is there a 
reason we have this printk?  Can we simply remove it?


Signed-off-by: Jerry Stralko <gerb.stralko@gmail.com>
---


diff --git a/drivers/scsi/sr_ioctl.c b/drivers/scsi/sr_ioctl.c
index ae87d08..c37fb1c 100644
--- a/drivers/scsi/sr_ioctl.c
+++ b/drivers/scsi/sr_ioctl.c
@@ -238,8 +238,6 @@ int sr_do_ioctl(Scsi_CD *cd, struct packet_command *cgc)
  					break;
  				}
  			}
-			if (!cgc->quiet)
-				printk(KERN_INFO "%s: CDROM not ready.  Make sure there is a disc in the drive.\n", cd->cdi.name);
  #ifdef DEBUG
  			scsi_print_sense_hdr("sr", &sshdr);
  #endif
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH] scsi: remove CDROM not ready printk, Jerry Stralko, (Tue May 27, 3:02 pm)
Re: [PATCH] scsi: remove CDROM not ready printk, Andrew Morton, (Thu May 29, 3:41 am)
Re: [PATCH] scsi: remove CDROM not ready printk, James Bottomley, (Thu May 29, 10:05 am)
Re: [PATCH] scsi: remove CDROM not ready printk, Gerb Stralko, (Thu May 29, 10:35 am)
Re: [PATCH] scsi: remove CDROM not ready printk, James Bottomley, (Thu May 29, 10:55 am)
Re: [PATCH] scsi: remove CDROM not ready printk, Gerb Stralko, (Thu May 29, 11:04 am)
Re: [PATCH] scsi: remove CDROM not ready printk, James Bottomley, (Thu May 29, 11:22 am)
Re: [PATCH] scsi: remove CDROM not ready printk, Gerb Stralko, (Sun Jun 1, 8:45 pm)
Re: [PATCH] scsi: remove CDROM not ready printk, Matthew Wilcox, (Thu May 29, 10:51 am)