Re: [PATCH] ftrace: distinguish kretprobe'd functions in trace logs

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

To: Abhishek Sagar <sagar.abhishek@...>

Cc: Ingo Molnar <mingo@...>, Thomas Gleixner <tglx@...>, LKML <linux-kernel@...>

Subject: Re: [PATCH] ftrace: distinguish kretprobe'd functions in trace logs

Date: Tuesday, May 27, 2008 - 2:48 pm

On Wed, 28 May 2008, Abhishek Sagar wrote:
quoted text>
> But if irq_enter() has a kretprobe installed on it, the return value stored on the stack at each invocation is modified to divert the return to a kprobe trampoline function called kretprobe_trampoline(). So with this the trace would (currently) look like:
>
> <idle>-0     [00] 4154504455.781616: irq_enter <- kretprobe_trampoline
>
> Now this is quite misleading to the end user, as it suggests something that didn't actually happen. So just to avoid such misinterpretations, the inlined patch aims to output such a log as:
>
> <idle>-0     [00] 4154504455.781616: irq_enter <- [unknown/kretprobe'd]
>
>
> Signed-off-by: Abhishek Sagar <sagar.abhishek@gmail.com>

Thanks Abhishek,

Acked-by: Steven Rostedt <srostedt@redhat.com>

-- Steve

--
unsubscribe noticeTo unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:

[PATCH] ftrace: distinguish kretprobe'd functions in trace l..., Abhishek Sagar, (Tue May 27, 2:33 pm)

Re: [PATCH] ftrace: distinguish kretprobe'd functions in tra..., Steven Rostedt, (Thu Oct 30, 10:30 pm)

Re: [PATCH] ftrace: distinguish kretprobe'd functions in tra..., Steven Rostedt, (Fri Oct 31, 10:36 am)

Re: [PATCH] ftrace: distinguish kretprobe'd functions in tra..., Abhishek Sagar, (Fri Oct 31, 11:32 am)

Re: [PATCH] ftrace: distinguish kretprobe'd functions in tra..., Steven Rostedt, (Fri Oct 31, 11:50 am)

Re: [PATCH] ftrace: distinguish kretprobe'd functions in tra..., Abhishek Sagar, (Fri Oct 31, 3:33 pm)

[PATCH] ftrace: use kretprobe trampoline name to test in out..., Steven Rostedt, (Fri Oct 31, 3:44 pm)

Re: [PATCH] ftrace: use kretprobe trampoline name to test in..., Ingo Molnar, (Mon Nov 3, 5:41 am)

Re: [PATCH] ftrace: distinguish kretprobe'd functions in tra..., Steven Rostedt, (Tue May 27, 2:48 pm)

Re: [PATCH] ftrace: distinguish kretprobe'd functions in tra..., Ingo Molnar, (Mon Jun 2, 6:41 am)


linux-kernel:
Greg KH	Re: Dual-Licensing Linux Kernel with GPL V2 and GPL V3
Greg Kroah-Hartman	[PATCH 005/196] Chinese: add translation of SubmittingDrivers
Adrian Bunk	[1/6] 2.6.21-rc2: known regressions
Paul Jackson	Re: cpuset-remove-sched-domain-hooks-from-cpusets
git:

linux-netdev:
Linus Torvalds	Re: [GIT]: Networking
Gerrit Renker	[PATCH 27/37] dccp: Integration of dynamic feature activation - part 2 (server side)
Jarek Poplawski	[PATCH] pkt_sched: Destroy gen estimators under rtnl_lock().
Andrew Morton	Re: [BUG] New Kernel Bugs
openbsd-misc:

Re: [PATCH] ftrace: distinguish kretprobe'd functions in trace logs

Online users